-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.5.2 nuget fixes #5601
Release/1.5.2 nuget fixes #5601
Conversation
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming build and test work, this LGTM
maybe this was excluded during arcade transition? Did you make any changes to the pipeline on AzDo side during Arcade transition? I guess we could always change that filter and try it. |
I was finally able to figure out what I was doing wrong. They are running now. I realized though while I was trying to figure out why the 1.5.4 pr went just fine, its that the pr went into master, and not into release/1.5.4. Luckily, there are no changes that weren't already in there (the commit hash's are different, which is why it shows changes) so it didn't break anything. I will go ahead and create a pr to remove that pr, and then create the pr into the correct branch. |
There's no need to revert then, since the revert would just add another commit without a diff. You can just ignore the noop change. (we don't force push to master to erase it). |
Reverting test file and version.
Fixed testing version.
Since the myget feeds are deprecated, this PR is to change the feeds to the new URLs. Any version changes are due to different version being in the new feeds. It is the same fix as #5599, expect that since this release is on the old build system, it has additional changes relating to that.
I decided to fix this release since its the last one on the old build system and its also the last release that uses version 1 of tensorflow. I can imagine that people who can't upgrade to version 2 will need to use this in the future.