Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous use of TaskContinuationOptions in ThreadUtils.cs #5753

Merged
merged 1 commit into from
May 4, 2021

Conversation

stephentoub
Copy link
Member

This was supposed to be TaskCreationOptions. TaskContinuationOptions here will end up binding to the wrong ctor, and won't actually have the desired effect, which is to avoid blocking the thread completing this TCS.

Thanks @sharwell for flagging it with CA2247.

This was supposed to be TaskCreationOptions.
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #5753 (2c5f888) into main (ebc431f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5753      +/-   ##
==========================================
+ Coverage   68.38%   68.41%   +0.03%     
==========================================
  Files        1131     1131              
  Lines      241019   241217     +198     
  Branches    25024    25071      +47     
==========================================
+ Hits       164822   165032     +210     
+ Misses      69714    69702      -12     
  Partials     6483     6483              
Flag Coverage Δ
Debug 68.41% <100.00%> (+0.03%) ⬆️
production 63.04% <100.00%> (+0.01%) ⬆️
test 89.24% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.Core/Utilities/ThreadUtils.cs 83.67% <100.00%> (ø)
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 81.88% <0.00%> (-3.15%) ⬇️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 59.60% <0.00%> (-2.65%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.74% <0.00%> (-0.85%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.53% <0.00%> (-0.15%) ⬇️
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 100.00% <0.00%> (+0.05%) ⬆️
src/Microsoft.Data.Analysis/DataFrame.Join.cs 99.31% <0.00%> (+1.40%) ⬆️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0.00%> (+2.42%) ⬆️
...c/Microsoft.ML.Data/Prediction/PredictionEngine.cs 87.17% <0.00%> (+10.70%) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 100.00% <0.00%> (+20.51%) ⬆️

@michaelgsharp
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelgsharp michaelgsharp merged commit 19b2331 into dotnet:main May 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
@stephentoub stephentoub deleted the patch-1 branch May 17, 2023 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants