Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean translation #5780

Merged
merged 2 commits into from
May 4, 2021
Merged

Add Korean translation #5780

merged 2 commits into from
May 4, 2021

Conversation

metr0jw
Copy link
Contributor

@metr0jw metr0jw commented May 3, 2021

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@dnfadmin
Copy link

dnfadmin commented May 3, 2021

CLA assistant check
All CLA requirements met.

@metr0jw metr0jw marked this pull request as draft May 3, 2021 02:21
@metr0jw metr0jw marked this pull request as ready for review May 3, 2021 03:04
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #5780 (a5fa3dc) into main (9ece0ff) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5780      +/-   ##
==========================================
+ Coverage   68.33%   68.38%   +0.05%     
==========================================
  Files        1131     1131              
  Lines      241008   241008              
  Branches    25025    25025              
==========================================
+ Hits       164686   164817     +131     
+ Misses      69824    69703     -121     
+ Partials     6498     6488      -10     
Flag Coverage Δ
Debug 68.38% <ø> (+0.05%) ⬆️
production 63.03% <ø> (+0.06%) ⬆️
test 89.22% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 81.88% <0.00%> (-3.15%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 23.78% <0.00%> (-2.43%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.74% <0.00%> (-0.85%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 66.32% <0.00%> (+0.25%) ⬆️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 67.35% <0.00%> (+0.51%) ⬆️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 92.49% <0.00%> (+1.02%) ⬆️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 73.12% <0.00%> (+1.15%) ⬆️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 72.78% <0.00%> (+1.36%) ⬆️
test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs 89.04% <0.00%> (+1.96%) ⬆️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 88.56% <0.00%> (+3.07%) ⬆️
... and 2 more

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for translating it!

@michaelgsharp michaelgsharp merged commit fe477ca into dotnet:main May 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants