Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: exception need throw #5823

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Bug fix: exception need throw #5823

merged 1 commit into from
Jun 8, 2021

Conversation

feiyun0112
Copy link
Contributor

No description provided.

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #5823 (26b348e) into main (7c34ab9) will increase coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #5823      +/-   ##
==========================================
+ Coverage   68.37%   68.40%   +0.02%     
==========================================
  Files        1131     1134       +3     
  Lines      241291   241937     +646     
  Branches    25053    25112      +59     
==========================================
+ Hits       164993   165502     +509     
- Misses      69806    69917     +111     
- Partials     6492     6518      +26     
Flag Coverage Δ
Debug 68.40% <33.33%> (+0.02%) ⬆️
production 62.99% <33.33%> (-0.01%) ⬇️
test 89.29% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.TensorFlow/TensorflowUtils.cs 72.92% <0.00%> (+6.62%) ⬆️
src/Microsoft.ML.Vision/DnnRetrainTransform.cs 60.88% <0.00%> (ø)
src/Microsoft.ML.TensorFlow/TensorflowTransform.cs 84.70% <100.00%> (+5.22%) ⬆️
...osoft.ML.KMeansClustering/KMeansPlusPlusTrainer.cs 83.60% <0.00%> (-7.16%) ⬇️
src/Microsoft.ML.Data/Training/TrainerUtils.cs 65.86% <0.00%> (-3.82%) ⬇️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 85.49% <0.00%> (-3.08%) ⬇️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 71.42% <0.00%> (-1.37%) ⬇️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 71.96% <0.00%> (-1.16%) ⬇️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 91.46% <0.00%> (-1.03%) ⬇️
src/Microsoft.Data.Analysis/GroupBy.cs 97.68% <0.00%> (-0.81%) ⬇️
... and 30 more

@michaelgsharp michaelgsharp merged commit e01dc25 into dotnet:main Jun 8, 2021
@feiyun0112 feiyun0112 deleted the patch8 branch June 8, 2021 13:42
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants