Add VBufferDataFrameCoumn to DataFrame #6409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 7, 2022 16:33
beccamc
commented
Oct 25, 2022
|
@michaelgsharp could I get a review on this? Or @LittleLittleCloud? |
|
@beccamc looking into it now. Trying to figure out why things are failing. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
michaelgsharp
approved these changes
Nov 28, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6409 +/- ##
==========================================
- Coverage 68.46% 68.44% -0.02%
==========================================
Files 1165 1174 +9
Lines 246202 248037 +1835
Branches 25558 25909 +351
==========================================
+ Hits 168550 169772 +1222
- Misses 70967 71512 +545
- Partials 6685 6753 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding VBuffer type to the DataFrame. I modeled this off the of StringDataFrameColumn. I am not sure if a more complex approach is needed for the VBuffer type. An IDataView containing VBuffer type will convert to a DataFrame correctly.
Relevant issue: #5872