Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to official build pipeline #6423

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Updates to official build pipeline #6423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6350dbc
Fix TSA parameters to be unique to ML.NET
ericstj Nov 1, 2022
007d129
Add _BuildConfig variable used by arcade templates
ericstj Nov 1, 2022
588bce0
Update feed link for nightly builds
ericstj Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Alternatively, you can add the Microsoft.ML package from within Visual Studio's

Daily NuGet builds of the project are also available in our Azure DevOps feed:

> [https://pkgs.dev.azure.com/dnceng/public/_packaging/MachineLearning/nuget/v3/index.json](https://pkgs.dev.azure.com/dnceng/public/_packaging/MachineLearning/nuget/v3/index.json)
> [https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json](https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changing the internal feed location. right? I am just asking as sometimes I share that with other parties.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we discussed this with the arcade folks and they said we shouldn't maintain our own Artifacts feed. They wanted us to use the common dotnet-libraries feed just like other libraries similar to us. For example: https://github.com/dotnet/command-line-api/blob/main/README.md

The actual change that moved the feed was in de79b8a#diff-70773eb1e66297b0e83e4f7d57285bec90b978c662da1c90a5fcbcb1bc534688L346

If we wanted to bring back publishing to the other feed we can, but my goal is to get us as much as possible off "special cases"


## Building ML.NET (For contributors building ML.NET open source code)

Expand Down
26 changes: 17 additions & 9 deletions build/vsts-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,16 @@ resources:

- container: UbuntuCrossArm64Container
image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-mlnet-cross-arm64

variables:
- template: /eng/common-variables.yml
BuildConfig: Release
_BuildConfig: $(BuildConfig)
OfficialBuildId: $(BUILD.BUILDNUMBER)
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_MULTILEVEL_LOOKUP: 0
Codeql.Enabled: true
Codeql.SkipTaskAutoInjection: True #default to not inject CodeQL tasks, we'll enable it in a single job.

stages:
- stage: build
Expand Down Expand Up @@ -267,12 +275,12 @@ stages:
publishGdn: true
continueOnError: false
params: ' -SourceToolsList @("policheck","credscan")
-TsaInstanceURL $(_TsaInstanceURL)
-TsaProjectName $(_TsaProjectName)
-TsaNotificationEmail $(_TsaNotificationEmail)
-TsaCodebaseAdmin $(_TsaCodebaseAdmin)
-TsaBugAreaPath $(_TsaBugAreaPath)
-TsaIterationPath $(_TsaIterationPath)
-TsaRepositoryName "machinelearning"
-TsaCodebaseName "machinelearning"
-TsaInstanceURL https://devdiv.visualstudio.com/
-TsaProjectName DEVDIV
-TsaNotificationEmail mlnetcore@microsoft.com
-TsaCodebaseAdmin REDMOND\ericstj
-TsaBugAreaPath "DevDiv\Net Libraries"
-TsaIterationPath DevDiv
-TsaRepositoryName machinelearning
-TsaCodebaseName machinelearning
-TsaPublish $True'
17 changes: 0 additions & 17 deletions eng/common-variables.yml
View file
Open in desktop

This file was deleted.