Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SentenceSimilarity sweepable estimator in AutoML #6445

Merged

Conversation

LittleLittleCloud
Copy link
Contributor

@LittleLittleCloud LittleLittleCloud commented Nov 10, 2022

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

dotnet/machinelearning-modelbuilder#2338 (comment)

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #6445 (128547a) into main (42788c4) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6445      +/-   ##
==========================================
- Coverage   68.57%   68.57%   -0.01%     
==========================================
  Files        1171     1171              
  Lines      247197   247197              
  Branches    25799    25799              
==========================================
- Hits       169515   169512       -3     
- Misses      70959    70960       +1     
- Partials     6723     6725       +2     
Flag Coverage Δ
Debug 68.57% <ø> (-0.01%) ⬇️
production 62.96% <ø> (-0.01%) ⬇️
test 88.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.Maml/MAML.cs 24.36% <0.00%> (-1.02%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.77% <0.00%> (-0.48%) ⬇️
src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs 79.77% <0.00%> (+0.27%) ⬆️

@@ -71,7 +71,8 @@
"DnnFeaturizerImage",
"Naive",
"ForecastBySsa",
"TextClassifcation"
"TextClassifcation",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you still use incorrect spelling because of this ?

"functionName": "TextClassifcation",

@michaelgsharp
Copy link
Member

@LittleLittleCloud if you can fix the conflict we can get this merged in.

@michaelgsharp michaelgsharp merged commit b1cb564 into dotnet:main Nov 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants