Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bail to default implementation upon any unforeseen situation #6538

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

rgesteve
Copy link
Contributor

Upon any unanticipated circumstance, bail to default implementation of an algorithm.

Most likely the dispatch logic will need to become more sophisticated as accelerated alternative implementations are added.

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #6538 (e446564) into main (6708456) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6538      +/-   ##
==========================================
- Coverage   68.39%   68.38%   -0.01%     
==========================================
  Files        1174     1174              
  Lines      248037   248049      +12     
  Branches    25909    25909              
==========================================
+ Hits       169633   169634       +1     
- Misses      71633    71644      +11     
  Partials     6771     6771              
Flag Coverage Δ
Debug 68.38% <40.00%> (-0.01%) ⬇️
production 62.75% <40.00%> (-0.01%) ⬇️
test 88.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.OneDal/OneDalUtils.cs 7.84% <ø> (ø)
...icrosoft.ML.FastTree/RandomForestClassification.cs 50.99% <40.00%> (-0.53%) ⬇️
...rc/Microsoft.ML.FastTree/RandomForestRegression.cs 53.77% <40.00%> (-0.37%) ⬇️
...Microsoft.ML.Mkl.Components/OlsLinearRegression.cs 56.06% <40.00%> (-0.28%) ⬇️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 85.74% <0.00%> (-1.14%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.77% <0.00%> (+0.15%) ⬆️
src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs 79.77% <0.00%> (+0.27%) ⬆️

@michaelgsharp michaelgsharp merged commit eeba2ee into dotnet:main Jan 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants