Skip to content

add checkAlive in NasBertTrainer #6546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023
Merged

add checkAlive in NasBertTrainer #6546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/Microsoft.ML.TorchSharp/NasBert/NasBertTrainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,8 @@ public override NasBertTransformer Fit(IDataView input)
for (int i = 0; i < Option.MaxEpoch; i++)
{
ch.Trace($"Starting epoch {i}");
trainer.Train(input);
Host.CheckAlive();
trainer.Train(Host, input);
ch.Trace($"Finished epoch {i}");
if (Option.ValidationSet != null)
trainer.Validate(pch, ch, i);
Expand Down Expand Up @@ -423,7 +424,7 @@ private bool ValidateStep(DataViewRowCursor cursor,
return cursorValid;
}

public void Train(IDataView input)
public void Train(IHost host, IDataView input)
{
// Get the cursor and the correct columns based on the inputs
DataViewRowCursor cursor = default;
Expand All @@ -443,14 +444,15 @@ public void Train(IDataView input)
var cursorValid = true;
while (cursorValid)
{
cursorValid = TrainStep(cursor, sentence1Getter, sentence2Getter, labelGetter, ref inputTensors, ref targets);
cursorValid = TrainStep(host, cursor, sentence1Getter, sentence2Getter, labelGetter, ref inputTensors, ref targets);
}
}

private bool TrainStep(DataViewRowCursor cursor,
ValueGetter<ReadOnlyMemory<char>> sentence1Getter,
ValueGetter<ReadOnlyMemory<char>> sentence2Getter,
ValueGetter<TLabelCol> labelGetter,
private bool TrainStep(IHost host,
DataViewRowCursor cursor,
ValueGetter<ReadOnlyMemory<char>> sentence1Getter,
ValueGetter<ReadOnlyMemory<char>> sentence2Getter,
ValueGetter<TLabelCol> labelGetter,
ref List<Tensor> inputTensors,
ref List<TTargetsCol> targets)
{
Expand All @@ -461,6 +463,7 @@ private bool TrainStep(DataViewRowCursor cursor,
var cursorValid = true;
for (int i = 0; i < Parent.Option.BatchSize && cursorValid; i++)
{
host.CheckAlive();
cursorValid = cursor.MoveNext();
if (cursorValid)
{
Expand All @@ -479,7 +482,7 @@ private bool TrainStep(DataViewRowCursor cursor,
}

Updates++;

host.CheckAlive();
torch.random.manual_seed(1 + Updates);
torch.cuda.manual_seed(1 + Updates);
Model.train();
Expand All @@ -497,8 +500,10 @@ private bool TrainStep(DataViewRowCursor cursor,
loss = torch.nn.MSELoss(reduction: Parent.Option.Reduction).forward(logits, targetsTensor);
logits = logits.squeeze();
}

host.CheckAlive();
loss.backward();

host.CheckAlive();
OptimizeStep();

return cursorValid;
Expand Down