Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing MSIL check for TorchSharp for now #6658

Merged
merged 1 commit into from
May 5, 2023

Conversation

michaelgsharp
Copy link
Member

Currently the TorchSharp nuget is targetting x64 only while we are targeting AnyCPU. TorchSharp is targetting x64 because right now they only package the x64 binaries. We are targeting AnyCPU because in theory if someone compiled their own native code for non x64 and dropped it in it should still work.

Disabling the check for MSB3270 for now to resolve the issue. Will need to address this again when TorchSharp changes.

@JakeRadMSFT
Copy link
Contributor

It might be worth warning? I'm fine either way.

@michaelgsharp
Copy link
Member Author

@JakeRadMSFT we treat warnings as errors, so making this warn will still throw an error for us. The real way to do it would be to add a targets file in the nuget that somehow checks for something like this. That can come in later though as this is blocking some builds now.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #6658 (5d921dc) into main (ce9938d) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6658      +/-   ##
==========================================
+ Coverage   68.57%   68.58%   +0.01%     
==========================================
  Files        1200     1200              
  Lines      250309   250326      +17     
  Branches    26095    26096       +1     
==========================================
+ Hits       171647   171698      +51     
+ Misses      71843    71814      -29     
+ Partials     6819     6814       -5     
Flag Coverage Δ
Debug 68.58% <ø> (+0.01%) ⬆️
production 63.07% <ø> (+0.01%) ⬆️
test 88.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit 896d69a into dotnet:main May 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2023
@michaelgsharp michaelgsharp deleted the torchsharp-msil branch November 18, 2024 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants