Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ExperimentSettings.MaxModel as public #6663

Merged
merged 1 commit into from
May 8, 2023

Conversation

LittleLittleCloud
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #6663 (55b6197) into main (3986fcf) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6663   +/-   ##
=======================================
  Coverage   68.59%   68.59%           
=======================================
  Files        1200     1200           
  Lines      250326   250326           
  Branches    26096    26096           
=======================================
+ Hits       171701   171706    +5     
+ Misses      71809    71807    -2     
+ Partials     6816     6813    -3     
Flag Coverage Δ
Debug 68.59% <ø> (+<0.01%) ⬆️
production 63.07% <ø> (+<0.01%) ⬆️
test 88.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit ff3b1b9 into main May 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants