Fix the behavior or column SetName method #6676

asmirnov82 · 2023-05-14T07:39:36Z

Add references to parent DataFrames inside the column. Column renaming updates metadata of all dataframes that this column belongs to.

Fixes #6129
Fixes #5916
Fixes #6682

…lumn_renaming

codecov · 2023-05-17T21:55:21Z

Codecov Report

Merging #6676 (cdb2bb6) into main (184e661) will increase coverage by 0.00%.
The diff coverage is 92.15%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6676   +/-   ##
=======================================
  Coverage   68.87%   68.88%           
=======================================
  Files        1216     1216           
  Lines      250915   250958   +43     
  Branches    26259    26261    +2     
=======================================
+ Hits       172825   172865   +40     
- Misses      71265    71274    +9     
+ Partials     6825     6819    -6

Flag	Coverage Δ
Debug	`68.88% <92.15%> (+<0.01%)`	⬆️
production	`63.37% <86.20%> (+<0.01%)`	⬆️
test	`88.91% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...crosoft.Data.Analysis/DataFrameColumnCollection.cs	`81.06% <70.00%> (-0.56%)`	⬇️
src/Microsoft.Data.Analysis/DataFrameColumn.cs	`67.14% <93.75%> (+2.61%)`	⬆️
src/Microsoft.Data.Analysis/DataFrame.Join.cs	`94.87% <100.00%> (ø)`
src/Microsoft.Data.Analysis/DataFrame.cs	`86.45% <100.00%> (ø)`
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs	`99.27% <100.00%> (+<0.01%)`	⬆️

... and 9 files with indirect coverage changes

michaelgsharp · 2023-06-01T19:10:16Z

/azp run

azure-pipelines · 2023-06-01T19:10:28Z

Azure Pipelines successfully started running 2 pipeline(s).

michaelgsharp

LGTM. Thanks for submitting this!

michaelgsharp · 2023-06-13T21:33:09Z

Hey @asmirnov82, looks like these changes are causing a stack overflow.

Stack overflow.
   at System.Collections.Generic.Dictionary`2[[System.__Canon, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].FindValue(System.__Canon)
   at System.Collections.Generic.Dictionary`2[[System.__Canon, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].get_Item(System.__Canon)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)
   at Microsoft.Data.Analysis.DataFrameColumnCollection.UpdateColumnNameMetadata(Microsoft.Data.Analysis.DataFrameColumn, System.String)
   at Microsoft.Data.Analysis.DataFrameColumn.SetName(System.String)

Can you take another look at it? You should be able to repro locally by running the tests in Microsoft.Data.Analysis.Tests. I'm not sure which test exactly is failing since its blowing up before its able to print out the test name.

…lumn_renaming # Conflicts: # src/Microsoft.Data.Analysis/DataFrameColumnCollection.cs

asmirnov82 · 2023-06-14T10:03:22Z

Hello @michaelgsharp, stack overflow is fixed

…lumn_renaming

JakeRadMSFT · 2023-06-23T18:10:55Z

Merged into Generic Math branch. (This is just a note for myself)

JakeRadMSFT · 2023-06-23T18:45:20Z

/azp run

azure-pipelines · 2023-06-23T18:45:31Z

Azure Pipelines successfully started running 2 pipeline(s).

Fix the behavior or column SetName method

535ac07

ghost added the community-contribution label May 14, 2023

Merge remote-tracking branch 'origin/main' into 5916_fix_dataframe_co…

9e7ba4d

…lumn_renaming

This was referenced May 18, 2023

DataFrame (Microsoft.Data.Analysis) Tracking Issue #6144

Open

Integrate latest dataframe changes from asmirnov/machinelearning into local branch JakeRadMSFT/machinelearning#2

Merged

michaelgsharp approved these changes Jun 1, 2023

View reviewed changes

Merge branch 'main' into 5916_fix_dataframe_column_renaming

f4d3464

asmirnov82 added 3 commits June 14, 2023 10:56

Merge remote-tracking branch 'origin/main' into 5916_fix_dataframe_co…

16dc7c6

…lumn_renaming # Conflicts: # src/Microsoft.Data.Analysis/DataFrameColumnCollection.cs

Fix stack overflow exception

f52eca0

Fix merge issues

3489632

Merge remote-tracking branch 'origin/main' into 5916_fix_dataframe_co…

cdb2bb6

…lumn_renaming

JakeRadMSFT merged commit 53c0f26 into dotnet:main Jul 6, 2023

asmirnov82 deleted the 5916_fix_dataframe_column_renaming branch July 7, 2023 05:57

ghost locked as resolved and limited conversation to collaborators Aug 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the behavior or column SetName method #6676

Fix the behavior or column SetName method #6676

asmirnov82 commented May 14, 2023 •

edited

Loading

codecov bot commented May 17, 2023 •

edited

Loading

michaelgsharp commented Jun 1, 2023

azure-pipelines bot commented Jun 1, 2023

michaelgsharp left a comment

michaelgsharp commented Jun 13, 2023

asmirnov82 commented Jun 14, 2023

JakeRadMSFT commented Jun 23, 2023

JakeRadMSFT commented Jun 23, 2023

azure-pipelines bot commented Jun 23, 2023

Fix the behavior or column SetName method #6676

Fix the behavior or column SetName method #6676

Conversation

asmirnov82 commented May 14, 2023 • edited Loading

codecov bot commented May 17, 2023 • edited Loading

Codecov Report

michaelgsharp commented Jun 1, 2023

azure-pipelines bot commented Jun 1, 2023

michaelgsharp left a comment

Choose a reason for hiding this comment

michaelgsharp commented Jun 13, 2023

asmirnov82 commented Jun 14, 2023

JakeRadMSFT commented Jun 23, 2023

JakeRadMSFT commented Jun 23, 2023

azure-pipelines bot commented Jun 23, 2023

asmirnov82 commented May 14, 2023 •

edited

Loading

codecov bot commented May 17, 2023 •

edited

Loading