Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build templates to handle feature branches #6744

Conversation

JakeRadMSFT
Copy link
Contributor

Updating build templates to handle feature branches.

@ghost ghost assigned JakeRadMSFT Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #6744 (d24e8a8) into main (8858ab6) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6744      +/-   ##
==========================================
- Coverage   68.89%   68.87%   -0.02%     
==========================================
  Files        1216     1216              
  Lines      250915   250915              
  Branches    26259    26259              
==========================================
- Hits       172857   172813      -44     
- Misses      71238    71273      +35     
- Partials     6820     6829       +9     
Flag Coverage Δ
Debug 68.87% <ø> (-0.02%) ⬇️
production 63.36% <ø> (-0.03%) ⬇️
test 88.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

@@ -18,6 +18,7 @@ schedules:
- releases/1.6.0
- features/automl
- features/integrationPackage
- feature/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove those other explicit features, and maybe we should add a release wildcard as well. What do you think @michaelgsharp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it and figured it would come up in the PR :).

The other ones are "features" but I'm not sure if we still need them?

+1 on releases!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be release/*. Probably this is somewhat stale.

Copy link
Contributor Author

@JakeRadMSFT JakeRadMSFT Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - happy to change it but all the old branches are - releases/* . Should I update the template to be release/* but leave the old branches named the same?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old branches are effectively dead now and won’t be building any more. Our servicing policy is roll forward to latest

@JakeRadMSFT JakeRadMSFT merged commit 4c799ab into dotnet:main Jun 28, 2023
@JakeRadMSFT JakeRadMSFT deleted the u/jakerad/update-builds-for-feature-branches branch June 28, 2023 00:03
@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants