-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build templates to handle feature branches #6744
Update build templates to handle feature branches #6744
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6744 +/- ##
==========================================
- Coverage 68.89% 68.87% -0.02%
==========================================
Files 1216 1216
Lines 250915 250915
Branches 26259 26259
==========================================
- Hits 172857 172813 -44
- Misses 71238 71273 +35
- Partials 6820 6829 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -18,6 +18,7 @@ schedules: | |||
- releases/1.6.0 | |||
- features/automl | |||
- features/integrationPackage | |||
- feature/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should remove those other explicit features, and maybe we should add a release wildcard as well. What do you think @michaelgsharp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it and figured it would come up in the PR :).
The other ones are "features" but I'm not sure if we still need them?
+1 on releases!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be release/*. Probably this is somewhat stale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - happy to change it but all the old branches are - releases/* . Should I update the template to be release/* but leave the old branches named the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old branches are effectively dead now and won’t be building any more. Our servicing policy is roll forward to latest
Updating build templates to handle feature branches.