Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernized some argument checks that still used string literals for parameter names #6766

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Jul 18, 2023

No changes in behavior, just leveraging more modern syntax

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #6766 (ec49f0c) into main (caee3c2) will increase coverage by 0.03%.
The diff coverage is 94.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6766      +/-   ##
==========================================
+ Coverage   68.88%   68.91%   +0.03%     
==========================================
  Files        1216     1216              
  Lines      251137   251401     +264     
  Branches    26269    26322      +53     
==========================================
+ Hits       172997   173265     +268     
+ Misses      71313    71270      -43     
- Partials     6827     6866      +39     
Flag Coverage Δ
Debug 68.91% <94.35%> (+0.03%) ⬆️
production 63.42% <89.01%> (+0.03%) ⬆️
test 88.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.Data.Analysis/DataFrame.IO.cs 80.60% <ø> (-0.17%) ⬇️
....Data.Analysis/DataFrameColumn.BinaryOperations.cs 0.00% <0.00%> (ø)
...a.Analysis/PrimitiveDataFrameColumnComputations.cs 50.37% <ø> (+0.56%) ⬆️
...crosoft.ML.Core/ComponentModel/ComponentCatalog.cs 70.24% <0.00%> (ø)
src/Microsoft.ML.TorchSharp/Utils/Index.cs 29.41% <0.00%> (ø)
src/Microsoft.ML.TorchSharp/Utils/Range.cs 31.57% <0.00%> (ø)
src/Microsoft.Data.Analysis/DateTimeComputation.cs 39.16% <100.00%> (+2.64%) ⬆️
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs 87.19% <100.00%> (+3.57%) ⬆️
...lysis/PrimitiveDataFrameColumn.BinaryOperations.cs 41.52% <100.00%> (+0.06%) ⬆️
....Analysis/PrimitiveDataFrameColumn.Computations.cs 77.77% <100.00%> (ø)
... and 4 more

... and 8 files with indirect coverage changes

@Lehonti
Copy link
Contributor Author

Lehonti commented Aug 6, 2023

@LittleLittleCloud , @michaelgsharp , @JakeRadMSFT , any plans to merge this? It's a quick and easy way to improve the codebase

@LittleLittleCloud
Copy link
Contributor

LittleLittleCloud commented Aug 7, 2023

LGTM, thanks for the contribution

@LittleLittleCloud LittleLittleCloud merged commit 077a6b8 into dotnet:main Aug 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants