Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with addIndexColumn in DataFrame.LoadCsv #6769

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Fix issue with addIndexColumn in DataFrame.LoadCsv #6769

merged 2 commits into from
Aug 25, 2023

Conversation

asmirnov82
Copy link
Contributor

Fixes #5968

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #6769 (3093a20) into main (caee3c2) will increase coverage by 0.02%.
The diff coverage is 97.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6769      +/-   ##
==========================================
+ Coverage   68.88%   68.91%   +0.02%     
==========================================
  Files        1216     1216              
  Lines      251137   251409     +272     
  Branches    26269    26323      +54     
==========================================
+ Hits       172997   173252     +255     
+ Misses      71313    71290      -23     
- Partials     6827     6867      +40     
Flag Coverage Δ
Debug 68.91% <97.80%> (+0.02%) ⬆️
production 63.40% <95.45%> (+0.02%) ⬆️
test 88.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....Data.Analysis/DataFrameColumn.BinaryOperations.cs 0.00% <0.00%> (ø)
...a.Analysis/PrimitiveDataFrameColumnComputations.cs 50.37% <ø> (+0.56%) ⬆️
src/Microsoft.Data.Analysis/DataFrame.IO.cs 82.54% <100.00%> (+1.77%) ⬆️
src/Microsoft.Data.Analysis/DateTimeComputation.cs 39.16% <100.00%> (+2.64%) ⬆️
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs 87.19% <100.00%> (+3.57%) ⬆️
...lysis/PrimitiveDataFrameColumn.BinaryOperations.cs 41.52% <100.00%> (+0.06%) ⬆️
....Analysis/PrimitiveDataFrameColumn.Computations.cs 77.77% <100.00%> (ø)
...oft.Data.Analysis/PrimitiveDataFrameColumn.Sort.cs 87.34% <100.00%> (ø)
...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs 81.39% <100.00%> (+0.52%) ⬆️
...Analysis/StringDataFrameColumn.BinaryOperations.cs 82.78% <100.00%> (+3.37%) ⬆️
... and 2 more

... and 8 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit 39235a7 into dotnet:main Aug 25, 2023
@asmirnov82 asmirnov82 deleted the load_csv_add_index_column_fix branch August 26, 2023 21:29
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addIndexColumn in DataFrame.LoadCsv doesn't work
3 participants