Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Boxing/Unboxing on accessing elements of VBufferDataFrameColumn (fix merge issues) #6867

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Avoid Boxing/Unboxing on accessing elements of VBufferDataFrameColumn (fix merge issues) #6867

merged 3 commits into from
Oct 17, 2023

Conversation

asmirnov82
Copy link
Contributor

Fixes #6864

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #6867 (67036d0) into main (766569b) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #6867      +/-   ##
==========================================
- Coverage   69.40%   69.39%   -0.02%     
==========================================
  Files        1238     1238              
  Lines      249441   249441              
  Branches    25522    25520       -2     
==========================================
- Hits       173130   173105      -25     
- Misses      69692    69716      +24     
- Partials     6619     6620       +1     
Flag Coverage Δ
Debug 69.39% <60.00%> (-0.02%) ⬇️
production 63.92% <60.00%> (-0.02%) ⬇️
test 88.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Microsoft.Data.Analysis/VBufferDataFrameColumn.cs 45.77% <60.00%> (-1.41%) ⬇️

... and 7 files with indirect coverage changes

@JakeRadMSFT JakeRadMSFT merged commit e825750 into dotnet:main Oct 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2023
@asmirnov82 asmirnov82 deleted the avoid_boxing_for_vbuffer_column branch April 7, 2024 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid boxing/unboxing in VBufferDataFrameColumn
2 participants