Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes NER to correctly expand/shrink the labels #6928

Merged
merged 5 commits into from
Jan 6, 2024

Conversation

michaelgsharp
Copy link
Member

NER now will correctly expand/shrink the labels when a word is split into multiple tokens.

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (a60be5f) 68.80% compared to head (9a2da18) 68.80%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6928    +/-   ##
========================================
  Coverage   68.80%   68.80%            
========================================
  Files        1249     1249            
  Lines      249433   249638   +205     
  Branches    25510    25481    -29     
========================================
+ Hits       171613   171774   +161     
- Misses      71210    71271    +61     
+ Partials     6610     6593    -17     
Flag Coverage Δ
Debug 68.80% <70.45%> (+<0.01%) ⬆️
production 63.27% <95.45%> (+0.01%) ⬆️
test 88.41% <59.74%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Microsoft.ML.TorchSharp/NasBert/NasBertTrainer.cs 80.36% <100.00%> (+0.24%) ⬆️
...c/Microsoft.ML.TorchSharp/TorchSharpBaseTrainer.cs 84.98% <100.00%> (+1.36%) ⬆️
src/Microsoft.ML.TorchSharp/NasBert/NerTrainer.cs 91.10% <94.73%> (+2.86%) ⬆️
test/Microsoft.ML.Tests/NerTests.cs 67.02% <59.74%> (-32.98%) ⬇️

... and 17 files with indirect coverage changes

@ericstj ericstj requested a review from tarekgh January 2, 2024 20:57
@michaelgsharp michaelgsharp merged commit 8896dd2 into dotnet:main Jan 6, 2024
25 checks passed
@michaelgsharp
Copy link
Member Author

/backport to release/3.0

Copy link

github-actions bot commented Jan 8, 2024

Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/7453507161

Copy link

github-actions bot commented Jan 8, 2024

@michaelgsharp backporting to release/3.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: ner options fix
Applying: Ner fixed.
error: sha1 information is lacking or useless (src/Microsoft.ML.TorchSharp/NasBert/NerTrainer.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Ner fixed.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link

github-actions bot commented Jan 8, 2024

@michaelgsharp an error occurred while backporting to release/3.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@michaelgsharp
Copy link
Member Author

/backport to release/3.0

Copy link

github-actions bot commented Jan 8, 2024

Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/7454070942

@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
@michaelgsharp michaelgsharp deleted the ner-fixes branch November 18, 2024 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants