Remove SourceLink SDK references #7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also remove the other hits, i.e. Tools.props: https://github.com/search?q=repo%3Adotnet%2Fmachinelearning%20sourcelink&type=code |
|
I found quite a few other dead dependencies here that I was able to clean up. I have also confirmed that the binaries / pdbs / packages still have source link info after this change. |
ViktorHofer
approved these changes
Feb 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7037 +/- ##
=======================================
Coverage 68.79% 68.79%
=======================================
Files 1254 1254
Lines 250204 250204
Branches 25529 25529
=======================================
+ Hits 172129 172134 +5
+ Misses 71465 71460 -5
Partials 6610 6610
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ViktorHofer let me know that we no longer need to have explicit SDK references to these source-link packages.
I'm removing them and also testing the behavior of build to ensure we still have source-link info in our binaries per https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/sourcelink.