Skip to content

Change official build to use 1ES templates #7048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Mar 6, 2024
Merged

Change official build to use 1ES templates #7048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
af61cb8
auto-generated 1es conversion of arcade templates
Mar 1, 2024
4d22c32
Initial 1es conversion
Mar 1, 2024
b296634
gotta use name/value syntax in variables mixed w/ templates
Mar 1, 2024
bf2d4ca
typos
Mar 1, 2024
0d18029
copy-paste error
Mar 1, 2024
68214f4
use more @self
Mar 1, 2024
4e6269f
use even more @self
Mar 1, 2024
c9f0d79
Try compliant replacement for PublishBuildArtifacts
Mar 1, 2024
98428d3
fix pool
Mar 1, 2024
33b623d
fix image
Mar 1, 2024
369c134
pipelineArtifact->buildArtifact
Mar 1, 2024
3e12489
typo
Mar 1, 2024
0025d9d
use vs2019 as before, not 2022
Mar 1, 2024
89b4f05
try enabling cfg and spectre mitigation on Windows
Mar 4, 2024
c6ead2b
Update Arcade
Mar 4, 2024
f678121
oops
Mar 4, 2024
fd9fb10
See if it's publish: to blame
Mar 4, 2024
f03cbf3
Revert "See if it's publish: to blame"
Mar 4, 2024
d6a6e11
Avoid artifacts: stanza
Mar 4, 2024
c4abc44
don't binskim source
Mar 4, 2024
e7e1e8d
try autobaselining
Mar 5, 2024
32d0c32
Merge remote-tracking branch 'origin/main' into 1es-test
Mar 5, 2024
06a30fe
Annotate disabled log upload
Mar 5, 2024
f557199
Remove AI tooling tag
directhex Mar 5, 2024
ce3126b
Move image names into variables & dedup
directhex Mar 5, 2024
f463720
Useless bad commit to force CI re-run
Mar 6, 2024
d9cfbbc
Revert "Useless bad commit to force CI re-run"
Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
616 changes: 314 additions & 302 deletions build/vsts-ci.yml
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions src/Native/CpuMathNative/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,9 @@ endif()

add_library(CpuMathNative SHARED ${SOURCES} ${RESOURCES})

if (MSVC AND NOT MSVC_VERSION LESS 1900)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /guard:cf")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Qspectre")
endif()

install_library_and_symbols (CpuMathNative)
5 changes: 5 additions & 0 deletions src/Native/FastTreeNative/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,9 @@ endif()

add_library(FastTreeNative SHARED ${SOURCES} ${RESOURCES})

if (MSVC AND NOT MSVC_VERSION LESS 1900)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /guard:cf")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Qspectre")
endif()

install_library_and_symbols (FastTreeNative)
5 changes: 5 additions & 0 deletions src/Native/LdaNative/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ set(SOURCES

add_library(LdaNative SHARED ${SOURCES} ${RESOURCES})

if (MSVC AND NOT MSVC_VERSION LESS 1900)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /guard:cf")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Qspectre")
endif()

if (${ARCHITECTURE} STREQUAL "arm")
if (WIN32)
target_link_libraries(LdaNative shell32.lib)
Expand Down
5 changes: 5 additions & 0 deletions src/Native/MatrixFactorizationNative/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ endif()

add_library(MatrixFactorizationNative SHARED ${SOURCES} ${RESOURCES})

if (MSVC AND NOT MSVC_VERSION LESS 1900)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /guard:cf")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Qspectre")
endif()

if (${ARCHITECTURE} STREQUAL "arm")
if (WIN32)
target_link_libraries(MatrixFactorizationNative shell32.lib)
Expand Down
5 changes: 5 additions & 0 deletions src/Native/MklProxyNative/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ endif()
add_library(MklProxyNative SHARED ${SOURCES} ${RESOURCES})
target_link_libraries(MklProxyNative PUBLIC ${MKL_LIBRARY})

if (MSVC AND NOT MSVC_VERSION LESS 1900)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /guard:cf")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Qspectre")
endif()

if(APPLE)
set_target_properties(MklProxyNative PROPERTIES INSTALL_RPATH "@loader_path")
endif()
Expand Down
4 changes: 4 additions & 0 deletions src/Native/OneDalNative/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,9 @@ endif()

set(SOURCES OneDalAlgorithms.cpp)
add_library(OneDalNative SHARED ${SOURCES} ${RESOURCES})
if (MSVC AND NOT MSVC_VERSION LESS 1900)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /guard:cf")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Qspectre")
endif()
target_link_libraries(OneDalNative PUBLIC ${WRAPPER_LINK_OPTIONS})
install_library_and_symbols(OneDalNative)
4 changes: 4 additions & 0 deletions src/Native/SymSgdNative/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ endif()

add_definitions(-DUSE_OMP)
add_library(SymSgdNative SHARED ${SOURCES} ${RESOURCES})
if (MSVC AND NOT MSVC_VERSION LESS 1900)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /guard:cf")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Qspectre")
endif()
target_link_libraries(SymSgdNative PUBLIC ${MKL_LIBRARY} PUBLIC ${OPENMP_LIBRARY})

if(APPLE)
Expand Down