Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package versions in use by ML.NET tests #7055

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Mar 11, 2024

Will backport this to the 3.0 branch too.

This also updates Newtonsoft which is a product dependency - but only updates to the latest servicing release which we can do as a servicing release ourselves.

Will backport this to the 3.0 branch too.

This also updates Newtonsoft which is a product dependency - but only
updates to the latest servicing release which we can do as a servicing
release ourselves.
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

I noticed we are not using the latest of Google.Protobuf which is 3.25.3. No strong reason to upgrade. Just wanted to mention it.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (59973fc) to head (b3b2f24).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7055      +/-   ##
==========================================
- Coverage   68.82%   68.82%   -0.01%     
==========================================
  Files        1255     1255              
  Lines      250358   250358              
  Branches    25550    25550              
==========================================
- Hits       172306   172300       -6     
- Misses      71440    71444       +4     
- Partials     6612     6614       +2     
Flag Coverage Δ
Debug 68.82% <ø> (-0.01%) ⬇️
production 63.25% <ø> (-0.01%) ⬇️
test 88.50% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@ericstj
Copy link
Member Author

ericstj commented Mar 12, 2024

Let's update Protobuf separately. That one doesn't have a CG warning and it's across minor versions: 3.19.6 -> 3.25.3.

@ericstj ericstj merged commit 86c11e1 into dotnet:main Mar 12, 2024
25 checks passed
@ericstj
Copy link
Member Author

ericstj commented Mar 12, 2024

/backport to release/3.0

Copy link

Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/8256116339

@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants