-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package versions in use by ML.NET tests #7055
Conversation
Will backport this to the 3.0 branch too. This also updates Newtonsoft which is a product dependency - but only updates to the latest servicing release which we can do as a servicing release ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
I noticed we are not using the latest of Google.Protobuf
which is 3.25.3
. No strong reason to upgrade. Just wanted to mention it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7055 +/- ##
==========================================
- Coverage 68.82% 68.82% -0.01%
==========================================
Files 1255 1255
Lines 250358 250358
Branches 25550 25550
==========================================
- Hits 172306 172300 -6
- Misses 71440 71444 +4
- Partials 6612 6614 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Let's update Protobuf separately. That one doesn't have a CG warning and it's across minor versions: |
… cg-updates-03-2024
/backport to release/3.0 |
Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/8256116339 |
Will backport this to the 3.0 branch too.
This also updates Newtonsoft which is a product dependency - but only updates to the latest servicing release which we can do as a servicing release ourselves.