Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated remote executor #7295

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

michaelgsharp
Copy link
Member

@michaelgsharp michaelgsharp commented Nov 8, 2024

Updates remote executor so that we can update the maintenance packages.

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.87%. Comparing base (3659a48) to head (52abd6a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7295      +/-   ##
==========================================
+ Coverage   68.84%   68.87%   +0.03%     
==========================================
  Files        1471     1470       -1     
  Lines      274124   273991     -133     
  Branches    28411    28399      -12     
==========================================
- Hits       188724   188721       -3     
+ Misses      78085    77956     -129     
+ Partials     7315     7314       -1     
Flag Coverage Δ
Debug 68.87% <100.00%> (+0.03%) ⬆️
production 63.28% <ø> (-0.01%) ⬇️
test 89.42% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/Microsoft.ML.CpuMath.UnitTests/UnitTests.cs 95.70% <100.00%> (ø)

... and 20 files with indirect coverage changes

@ericstj
Copy link
Member

ericstj commented Nov 9, 2024

TorchSharp tests failing - most likely with OOM killer.
https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-7295-merge-d2e8baee8ed043a68d/Microsoft.ML.TorchSharp.Tests/1/console.ce1a649e.log

�[mStarting test: Microsoft.ML.TorchSharp.Tests.QATests.TestSimpleQA
Killed
+ export _commandExitCode=137

https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-7295-merge-40b990e0aede49fb90/Microsoft.ML.TorchSharp.Tests/1/console.5d0e316a.log

Starting test: Microsoft.ML.TorchSharp.Tests.QATests.TestSimpleQA
/root/helix/work/correlation/scripts/414952a5ab8241c581e5bf6333bbe3ec/execute.sh: line 9:    19 Killed                  dotnet exec --roll-forward Major --runtimeconfig Microsoft.ML.TorchSharp.Tests.runtimeconfig.json --depsfile Microsoft.ML.TorchSharp.Tests.deps.json $HELIX_CORRELATION_PAYLOAD/xunit-runner/tools/netcoreapp2.0/xunit.console.dll Microsoft.ML.TorchSharp.Tests.dll -notrait Category=SkipInCI -xml testResults.xml
+ export _commandExitCode=137
+ _commandExitCode=137

Should be #6978

@@ -21,17 +21,17 @@
<MicrosoftExtensionsOptionsVersion>8.0.2</MicrosoftExtensionsOptionsVersion>
<NuGetVersion>6.9.1</NuGetVersion>
<SkiaSharpVersion>2.88.8</SkiaSharpVersion>
<SystemBuffersVersion>4.5.1</SystemBuffersVersion>
<SystemBuffersVersion>4.6.0-preview.1.24529.4</SystemBuffersVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these are preview versions and we should not release consuming the preview versions.

@michaelgsharp
Copy link
Member Author

Merging on red since the only test failures are known test failures and we don't have the repo set up correctly for Build Analysis to be able to bypass it.

@michaelgsharp michaelgsharp merged commit 3e2ba81 into dotnet:main Nov 11, 2024
22 of 25 checks passed
@michaelgsharp
Copy link
Member Author

/backport to release/4.0

Copy link

@michaelgsharp michaelgsharp deleted the remote-executor branch November 11, 2024 23:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants