-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update dependencies from maintenance-packages #7412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| Bug in the latest version of VS points to a Version of FSharp.Core that doesn't exist. Temporarily ignoring | ||
| NU1603 so it will use the latest version found.--> | ||
| <NoWarn>NU1603;NU1604;2003;$(NoWarn)</NoWarn> | ||
| <NoWarn>NU1604;2003;$(NoWarn)</NoWarn> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an error related to System.ValueTuple, which we updated in maintenance-packages too. I am merely curious about the failure and want to see it happening. I couldn't get it to repro locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the NU1603 was for a version of FSharp.Core referenced by VS provided targets for fsproj, not ValueTuple. I think those targets referenced a version which wasn't available on our feeds. If we hit that again we should just make sure to mirror the version it's using to dotnet-public feed.
Looks like NU1604 was for value tuple 791e37e#diff-5c7e38da31722117952bacf9106591b3ec142e24b114c5172f5d634f9bce21d1R3-R5
Which would have been caused by an old version of FSharp that referenced ValueTuple from their nuspec without listing a version. dotnet/fsharp#12778
I bet both have been fixed now, so lets try removing them both.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7412 +/- ##
=======================================
Coverage 68.97% 68.97%
=======================================
Files 1481 1481
Lines 273696 273696
Branches 28285 28285
=======================================
+ Hits 188772 188773 +1
- Misses 77532 77534 +2
+ Partials 7392 7389 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
With this merged now we must publish the M-P release before we publish another preview of ML.NET cc @tarekgh @michaelgsharp |
System.Memory and System.Runtime.CompilerServices.Unsafe
Temporarily using the release feed until we push to nuget: https://dnceng.visualstudio.com/public/_artifacts/feed/darc-pub-dotnet-maintenance-packages-ab95a1f1