-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add OnnxTransform for scoring Onnx 1.2 models - integrates Microsoft.ML.Scoring/Sonoma Library #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
d67eb57
initial checkin
jignparm 1402d19
added 1 file
jignparm d7aefce
Added nugets and project so compile successfully
jignparm b5482df
Added unit tests -- need further debugging
jignparm 40f857e
Merge branch 'master' into jignparm/onnxtransform
jignparm 46d7821
Fixed schema propagation tests
jignparm 4bf00de
Merge remote-tracking branch 'upstream/master' into jignesh/onnx
dd956be
Merge branch 'jignparm/onnxtransform' of https://github.com/jignparm/…
jignparm e61b730
Cleaned up inconsistent multiple/single IO code. Now OnnxTransform is…
6fdd04e
Some minor fixes
jignparm e597068
Merge branch 'jignparm/onnxtransform' of https://github.com/jignparm/…
jignparm fd27eec
Updated tests
2778577
moved tests to different project to prevent tensorflow.dll from crashing
jignparm 27de2b0
unit tests passing
jignparm 4d94c43
relaxed range differences
jignparm 84334ed
Made factory create() methods private
4b958b1
Addressed some PR comments
7ff3012
Moved IdvToTensorAdapter to OnnxUtils
d47516e
Fixed blanks line
51b3c42
Merge branch 'master' into jignparm/onnxtransform
jignparm b9af85e
fixed merge conflicts
jignparm 8c880f0
Small clean up
d554822
added PR comments
jignparm 3069de6
Fixed PR code reviews
jignparm ca61e26
more PR comments
jignparm d95e323
Addressed Ivans PR comments
jignparm 24d34b4
added back onnx proj, removed onnxtransform proj
jignparm 0182ca1
small edit to kick off build
jignparm cc14268
doc changes
jignparm aa17a35
fixed gt to gt;
jignparm 4c7821f
small change to kick off build
jignparm 316a5a1
create IDV from array instead of list of array
jignparm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
pkg/Microsoft.ML.OnnxTransform/Microsoft.ML.OnnxTransform.nupkgproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk" DefaultTargets="Pack"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <PackageDescription>ML.NET component for Microsoft.ML.Scoring library</PackageDescription> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="../Microsoft.ML/Microsoft.ML.nupkgproj" /> | ||
| <PackageReference Include="Microsoft.ML.Scoring" Version="$(MicrosoftMLScoring)"/> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
5 changes: 5 additions & 0 deletions
5
pkg/Microsoft.ML.OnnxTransform/Microsoft.ML.OnnxTransform.symbols.nupkgproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <Project DefaultTargets="Pack"> | ||
|
|
||
| <Import Project="Microsoft.ML.OnnxTransform.nupkgproj" /> | ||
|
|
||
| </Project> |
15 changes: 15 additions & 0 deletions
15
src/Microsoft.ML.OnnxTransform/Microsoft.ML.OnnxTransform.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <IncludeInPackage>Microsoft.ML.OnnxTransform</IncludeInPackage> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\Microsoft.ML.Core\Microsoft.ML.Core.csproj" /> | ||
| <ProjectReference Include="..\Microsoft.ML.Data\Microsoft.ML.Data.csproj" /> | ||
| <PackageReference Include="Microsoft.ML.Scoring" Version="$(MicrosoftMLScoring)" /> | ||
| </ItemGroup> | ||
jignparm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| </Project> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the standup meeting, we want to keep
Microsoft.ML.OnnxTransformfrom being a stable package. A way to do that is to add this property here:Which will ensure that the
Versionwill still have-previewin it. #ResolvedUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See
machinelearning/Directory.Build.props
Lines 61 to 66 in 9258be2
$(StabilizePackageVersion)totruefor the build. #ResolvedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was another discussion post this mornings call.
The plan is to use this dev nuget for the bug-bash, and assuming bugs are fixed by Thursday and sonoma goes live before tuesday, we'll switch to point to the stable release of the nuget.
build/Dependencies.props: 1.0.4-dev48825
In reply to: 220290306 [](ancestors = 220290306)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was another discussion post this mornings call.
The plan is to use this dev nuget for the bug-bash, and assuming bugs are fixed by Thursday and sonoma goes live before tuesday, we'll switch to point to the stable release of the nuget.
build/Dependencies.props: 1.0.4-dev48825
In reply to: 220290881 [](ancestors = 220290881)