Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[uikit] Duplicate bindings for 'UIScrollView.ContentOffset' to get co…
…rrect availability information. Fixes #4893 (#5007) `ContentOffset` was moved to `UIFocusItemScrollableContainer` in iOS 12. Since it's a new protocol it's decorated as introduced in iOS 12 - but the API was actually already available for a long time. The _trick_ is to keep the original binding inside `UIScrollView` so it overrides the protocol and keeps the correct availability info. It requires adding `new` to bindings to avoid compiler warnings. reference: #4893 --- from @rolfbjarne In iOS 12 this property was moved to a protocol, but that protocol's availability attributes limits it to iOS 12, not iOS 2 where this property was originally introduced. This is problematic, because it means we'll throw a PlatformNotSupportedException if someone tries to call it on 32-bit iOS. So put the property back on UIScrollView, so that the generated code ends up with the right availability attributes (and a correct 32-bit implementation). #5004
- Loading branch information
1ec90f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Build was (probably) aborted
🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.13', Test docs' 🔥 : hudson.AbortException: script returned exit code 1
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 script returned exit code 1 🔥
✅ Test run succeeded