-
Notifications
You must be signed in to change notification settings - Fork 520
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #7009 from xamarin/d16-3-xcode11-v2
Merge xcode11 into d16-3 (updated).
- Loading branch information
Showing
55 changed files
with
1,532 additions
and
636 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
#if IOS || WATCH | ||
using System; | ||
using ObjCRuntime; | ||
|
||
namespace CoreBluetooth { | ||
public partial class CBManager { | ||
|
||
[iOS (13,0), Watch (6,0)] | ||
public static CBManagerAuthorization Authorization { | ||
get { | ||
// in iOS 13.1 / Watch 6.1 this is a static property, like other [tv|mac]OS | ||
#if IOS | ||
if (UIKit.UIDevice.CurrentDevice.CheckSystemVersion (13, 1)) { | ||
#elif WATCH | ||
if (WatchKit.WKInterfaceDevice.CurrentDevice.CheckSystemVersion (6, 1)) { | ||
#endif | ||
return _SAuthorization; | ||
} else { | ||
// in iOS 13.0 this was, shortly (deprecated in 13.1), an instance property | ||
return new CBCentralManager ()._IAuthorization; | ||
} | ||
} | ||
} | ||
} | ||
} | ||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#if !WATCH // doesn't show up in watch headers | ||
#if !MONOMAC | ||
using System; | ||
using ObjCRuntime; | ||
|
||
namespace MapKit { | ||
|
||
public enum MKMapCameraZoomRangeType { | ||
Min, | ||
Max, | ||
} | ||
|
||
public partial class MKMapCameraZoomRange { | ||
public MKMapCameraZoomRange (double distance) : this (distance, MKMapCameraZoomRangeType.Min) | ||
{ | ||
} | ||
|
||
public MKMapCameraZoomRange (double distance, MKMapCameraZoomRangeType type) | ||
{ | ||
// two different `init*` would share the same C# signature | ||
switch (type) { | ||
case MKMapCameraZoomRangeType.Min: | ||
InitializeHandle (InitWithMinCenterCoordinateDistance (distance)); | ||
break; | ||
case MKMapCameraZoomRangeType.Max: | ||
InitializeHandle (InitWithMaxCenterCoordinateDistance (distance)); | ||
break; | ||
default: | ||
throw new ArgumentException (nameof (type)); | ||
} | ||
} | ||
} | ||
} | ||
#endif | ||
#endif // !WATCH |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#if !WATCH // doesn't show up in watch headers | ||
#if !MONOMAC | ||
using System; | ||
using ObjCRuntime; | ||
|
||
namespace MapKit { | ||
|
||
public enum MKPointOfInterestFilterType { | ||
Including, | ||
Excluding, | ||
} | ||
|
||
public partial class MKPointOfInterestFilter { | ||
public MKPointOfInterestFilter (MKPointOfInterestCategory[] categories) : this (categories, MKPointOfInterestFilterType.Including) | ||
{ | ||
} | ||
|
||
public MKPointOfInterestFilter (MKPointOfInterestCategory[] categories, MKPointOfInterestFilterType type) | ||
{ | ||
// two different `init*` would share the same C# signature | ||
switch (type) { | ||
case MKPointOfInterestFilterType.Including: | ||
InitializeHandle (InitIncludingCategories (categories)); | ||
break; | ||
case MKPointOfInterestFilterType.Excluding: | ||
InitializeHandle (InitExcludingCategories (categories)); | ||
break; | ||
default: | ||
throw new ArgumentException (nameof (type)); | ||
} | ||
} | ||
} | ||
} | ||
#endif | ||
#endif // !WATCH |
Oops, something went wrong.
5e8a208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Device tests passed on iOS on Azure DevOps(iOS): Html Report ✅
Test results
All 70 tests passed
5e8a208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on TvOS on Azure DevOps(TvOS): Html Report 🔥
Test results
2 tests failed, 68 tests passed.
Failed tests
5e8a208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Build was (probably) aborted
🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥
✅ Build succeeded
✅ Packages:
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥
Test results
386 tests' device not found, 163 tests passed.
5e8a208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting state to
success
where context iscontinuous-integration/jenkins/branch
.Two known issues in the tvOS device tests: https://github.com/xamarin/maccore/issues/1614 https://github.com/xamarin/maccore/issues/1909. xHarness reports successes as failures due to missing devices, which is wrong.
5e8a208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting state to
success
where context isVSTS: device tests (TvOS)
.Two known issues in the tvOS device tests: https://github.com/xamarin/maccore/issues/1614 https://github.com/xamarin/maccore/issues/1909.