[Tests] Fix intro tests on older macOS #11736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested all of this on:
|
dalexsoto
approved these changes
May 28, 2021
spouliot
suggested changes
May 28, 2021
| case "MLFeatureValue": | ||
| case "MLSequence": | ||
| if (Mac.CheckSystemVersion (10, 15)) // Fail on Catalina, pass in older OS | ||
| return true; |
There was a problem hiding this comment.
that's skipping OS <= 10.15
if it pass on older you need a different check, like
// Fail on Catalina, pass in older OS
if (Mac.CheckSystemVersion (10, 14))
break;
if (Mac.CheckSystemVersion (10, 15))
return true;
// 11.x
break;| return TestRuntime.IsVM; // skip only on vms | ||
| case "NSMenuView": | ||
| return TestRuntime.IsVM || IntPtr.Size != 8; // skip on vms or 64b |
There was a problem hiding this comment.
we don't support 32bits for macOS anymore, you can always skip NSMenuView
|
|
||
| case "MetalPerformanceShaders.MPSPredicate": | ||
| if (Mac.CheckSystemVersion (10, 15)) // Fails on Catalina: Could not initialize an instance of the type 'MetalPerformanceShaders.MPSPredicate': the native 'init' method returned nil. | ||
| return true; |
There was a problem hiding this comment.
does it work on earlier macOS ?
if so see my other comment
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 80 tests passed.Failed tests
Pipeline on Agent XAMBOT-1098.BigSur |
rolfbjarne
approved these changes
May 31, 2021
tj-devel709
approved these changes
Jun 1, 2021
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 81 tests passed 🎉Pipeline on Agent XAMBOT-1099.BigSur |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results19 tests failed, 62 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 81 tests passed 🎉Pipeline on Agent XAMBOT-1101.BigSur |
spouliot
approved these changes
Jun 4, 2021
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place * add debugging Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place * add debugging * more debugging Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place * add debugging * more debugging * changing the label requirement for the tests Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place * add debugging * more debugging * changing the label requirement for the tests * more debugging 2 Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place * add debugging * more debugging * changing the label requirement for the tests * more debugging 2 * try more debugging Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place * add debugging * more debugging * changing the label requirement for the tests * more debugging 2 * try more debugging * changing to create new branch Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place * add debugging * more debugging * changing the label requirement for the tests * more debugging 2 * try more debugging * changing to create new branch * forgot to update the depends on Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place * add debugging * more debugging * changing the label requirement for the tests * more debugging 2 * try more debugging * changing to create new branch * forgot to update the depends on * adding soft-fail Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
tj-devel709
added a commit
that referenced
this pull request
Jun 4, 2021
* [Tests] Fix intro tests on older macOS (#11736) Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Seeing if pushing to this lego branch will create a PR inside AutomatingLocalizationGHATest * [Actions] Remove broken action. (#11819) Actions that are triggered from forks do not have access to the secrets making the action fail most of the time. We have moved to a github action in the static page repo that will clean results of closed PRs everyday. We remove this action because is broken and not needed. * try again * let's get the lego firing again * fire lego #3 * see if test gha occurs * trying after changing gha name * changing the branch (#11826) Co-authored-by: tj_devel709 <antlambe@microsoft.com> * after changing the GHA in main * perhaps the action was not updated yet * after merge main * wrong label * fire * adding sync to this branch * fixing env variable * conditionals in the wrong place * add debugging * more debugging * changing the label requirement for the tests * more debugging 2 * try more debugging * changing to create new branch * forgot to update the depends on * adding soft-fail * soft-fail -> soft_fail Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: tj_devel709 <antlambe@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.