[release/9.0.1xx-preview7] Enable dedup only when targeting ARM64 mobile platforms #20951
Conversation
ivanpovazan
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
📚 [CI Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
| <!-- | ||
| Enable dedup optimization whenever we run AOT compiler | ||
| The only exception is maccatalyst-x64 which uses AOT when the interpreter is also enabled. | ||
| In such setup, during runtime, AOT images are loaded but marked as unusuable as they are compiled with `full` compiler switch and the code fallsback to interpreter. |
There was a problem hiding this comment.
This comment is not accurate anymore, but lets clean up after we snap.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 100 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Description
Previous fix #20941 did not take into account that when we target non arm64 apple mobile platforms we are using
MONO_AOT_MODE_INTERP_ONLYwhich cannot use dedup optimization as it discards AOT images during runtime (as noted in: #20945).Changes
Finally, the change was tested against MAUI iossimulator-x64 template app