[release/8.0.1xx-xcode15.4] Enable dedup only when targeting arm64 platforms #20952
Conversation
dalexsoto
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
📚 [CI Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment was marked as outdated.
This comment was marked as outdated.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 98 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
| <!-- | ||
| Enable dedup optimization whenever we run AOT compiler | ||
| The only exception is maccatalyst-x64 which uses AOT when the interpreter is also enabled. | ||
| In such setup, during runtime, AOT images are loaded but marked as unusuable as they are compiled with `full` compiler switch and the code fallsback to interpreter. |
There was a problem hiding this comment.
This comment is not accurate anymore, but lets clean up after we snap.
This comment was marked as outdated.
This comment was marked as outdated.
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
Backport of #20952 -------- ## Description Previous fix #20945 did not take into account that when we target non arm64 apple mobile platforms we are using `MONO_AOT_MODE_INTERP_ONLY` which cannot use dedup optimization as it discards AOT images during runtime. ## Changes - Enable dedup only when targeting ARM64 - Fix tests to cover builds for both ARM64 and X64 builds Finally, the change was tested against MAUI iossimulator-x64 template app --------- Co-authored-by: Ivan Povazan <ivan.povazan@gmail.com> Co-authored-by: Ivan Povazan <55002338+ivanpovazan@users.noreply.github.com>
Description
Previous fix #20945 did not take into account that when we target non arm64 apple mobile platforms we are using
MONO_AOT_MODE_INTERP_ONLYwhich cannot use dedup optimization as it discards AOT images during runtime.Changes
Finally, the change was tested against MAUI iossimulator-x64 template app