[registrar] Fix resolving linked away generic types. Fixes #3523. #3539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spouliot
approved these changes
Feb 19, 2018
tests/mtouch/RegistrarTest.cs
Outdated
| { | ||
| // Normally compilable test code can go into monotouch-test, but in this case it depends on the | ||
| // generic type (NSSet) being linked away, and since monotouch-test uses NSSet, it's not linked | ||
| // away, and we don't hit the required condition causing the bug. |
Contributor
There was a problem hiding this comment.
maybe link sdk or link all would have fit the bill ?
Member
Author
There was a problem hiding this comment.
Good idea, I've put it in link all instead.
Collaborator
|
Build failure |
dalexsoto
approved these changes
Feb 20, 2018
It's much faster, since we're already building link all everywhere.
spouliot
approved these changes
Feb 20, 2018
| public void LinkedAwayGenericTypeAsOptionalMemberInProtocol () | ||
| { | ||
| // https://github.com/xamarin/xamarin-macios/issues/3523 | ||
| // This test will fail at build time if it regresses (usually these types of build tests go into monotouch-test, but monotouch-test uses NSSet<T> elsewhere, which this test requires to be linked away). |
Collaborator
|
Build failure |
VincentDondain
approved these changes
Feb 20, 2018
Collaborator
|
Build failure |
Collaborator
|
Build failure |
Member
Author
|
Test failure is unrelated:
|
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Feb 21, 2018
… (dotnet#3539) * [registrar] Fix resolving linked away generic types. Fixes dotnet#3523. Fixes dotnet#3523. * [tests] Use a link all test instead of mtouch test. It's much faster, since we're already building link all everywhere. * [tests] Use the static registrar in all linkall simulator configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3523.