Skip to content

[d15-7] Build with CSC instead of MCS (#3393) #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chamons merged 1 commit into from
Feb 26, 2018
Merged

[d15-7] Build with CSC instead of MCS (#3393) #3578

chamons merged 1 commit into from
Feb 26, 2018

Conversation

@chamons
Copy link
Contributor

@chamons chamons commented Feb 22, 2018

  • Improve error messages from install-source when crashing

@chamons
Build with CSC instead of MCS (dotnet#3393)
22f1246 
- Improve error messages from install-source when crashing
@chamons chamons requested a review from spouliot February 22, 2018 19:01
@spouliot spouliot added the do-not-merge Do not merge this pull request label Feb 22, 2018
@chamons chamons changed the title Build with CSC instead of MCS (#3393) [d15-7] Build with CSC instead of MCS (#3393) Feb 22, 2018
@spouliot
Copy link
Contributor

spouliot commented Feb 22, 2018

Let's wait for the bots to give us results from master (including device tests) before merging to d15-7

@spouliot spouliot added this to the d15-7 milestone Feb 22, 2018
@monojenkins
Copy link
Collaborator

monojenkins commented Feb 22, 2018

Build failure

@rolfbjarne
Copy link
Member

rolfbjarne commented Feb 26, 2018 •
edited
Loading

Device tests for master: all tvOS tests passed. No iOS/watchOS tests passed due to ongoing wifi network issues (this is unrelated).

@spouliot
Copy link
Contributor

spouliot commented Feb 26, 2018

As far as the compiler is involved I think it covered enough.
Additional testing will be done on 15.7 and better include this sooner than later.
Removing label.

@spouliot spouliot removed the do-not-merge Do not merge this pull request label Feb 26, 2018
@spouliot
Copy link
Contributor

spouliot commented Feb 26, 2018

@chamons unless other concerns were found let's merge this :)

@chamons
Copy link
Contributor Author

chamons commented Feb 26, 2018

Yeehaw. Landing compiler change in a release branch.

@chamons chamons merged commit e4b62a8 into dotnet:d15-7 Feb 26, 2018
@chamons chamons deleted the d15-7-csc branch February 26, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@spouliot spouliot Awaiting requested review from spouliot

@emaf emaf Awaiting requested review from emaf emaf is a code owner

@kzu kzu Awaiting requested review from kzu

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner

+2 more reviewers

@jstedfast jstedfast jstedfast approved these changes

@VincentDondain VincentDondain VincentDondain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

d15-7

Development

Successfully merging this pull request may close these issues.

7 participants

@chamons @spouliot @monojenkins @rolfbjarne @dalexsoto @jstedfast @VincentDondain