[static registrar] Make sure to include frameworks for linked away protocol types as well. #3617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otocol types as well.
At some point the code wasn't able to figure out the framework for linked away
types (because linked away types don't know which assembly they belong to, and
thus we couldn't verify that the type in question was a platform type or not),
so I skipped checking the namespace for such types.
Some time later I implemented support for storing the assembly for a linked
away type separately, so that it can later be looked up, and thus it's not
necessary to exclude linked away types anymore.
This fixes a build problem with the generated registrar code (which happens
only if the INCWidgetProviding interface is linked away) when building the
linkall extension tests:
/work/maccore/master/xamarin-macios/tests/xharness/tmp-test-dir/link all1894/obj/iPhone/Debug64-today-extension/mtouch-cache/registrar.h:319:51: error: no type or protocol named 'NCWidgetProviding'
@interface TodayViewController : UIViewController<NCWidgetProviding> {
^
Collaborator
|
Build failure |
Member
Author
|
Test failures are unrelated: |
spouliot
approved these changes
Mar 1, 2018
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Mar 1, 2018
…otocol types as well. (dotnet#3617) At some point the code wasn't able to figure out the framework for linked away types (because linked away types don't know which assembly they belong to, and thus we couldn't verify that the type in question was a platform type or not), so I skipped checking the namespace for such types. Some time later I implemented support for storing the assembly for a linked away type separately, so that it can later be looked up, and thus it's not necessary to exclude linked away types anymore. This fixes a build problem with the generated registrar code (which happens only if the INCWidgetProviding interface is linked away) when building the linkall extension tests: /work/maccore/master/xamarin-macios/tests/xharness/tmp-test-dir/link all1894/obj/iPhone/Debug64-today-extension/mtouch-cache/registrar.h:319:51: error: no type or protocol named 'NCWidgetProviding' @interface TodayViewController : UIViewController<NCWidgetProviding> { ^
rolfbjarne
added a commit
that referenced
this pull request
Mar 5, 2018
…otocol types as well. (#3617) (#3629) At some point the code wasn't able to figure out the framework for linked away types (because linked away types don't know which assembly they belong to, and thus we couldn't verify that the type in question was a platform type or not), so I skipped checking the namespace for such types. Some time later I implemented support for storing the assembly for a linked away type separately, so that it can later be looked up, and thus it's not necessary to exclude linked away types anymore. This fixes a build problem with the generated registrar code (which happens only if the INCWidgetProviding interface is linked away) when building the linkall extension tests: /work/maccore/master/xamarin-macios/tests/xharness/tmp-test-dir/link all1894/obj/iPhone/Debug64-today-extension/mtouch-cache/registrar.h:319:51: error: no type or protocol named 'NCWidgetProviding' @interface TodayViewController : UIViewController<NCWidgetProviding> { ^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point the code wasn't able to figure out the framework for linked away
types (because linked away types don't know which assembly they belong to, and
thus we couldn't verify that the type in question was a platform type or not),
so I skipped checking the namespace for such types.
Some time later I implemented support for storing the assembly for a linked
away type separately, so that it can later be looked up, and thus it's not
necessary to exclude linked away types anymore.
This fixes a build problem with the generated registrar code (which happens
only if the INCWidgetProviding interface is linked away) when building the
linkall extension tests: