[tests] Don't run mmp regression tests in parallel. Fixes maccore #645. #3638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…net#645. For some reason vstool becomes confused and starts erroring out if multiple vstools are running at the same time. So work around this by executing the MMP regression tests serialized. Fixes xamarin/maccore#645.
spouliot
approved these changes
Mar 1, 2018
Contributor
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
That sounds like a bad bug for vstool, can you file an issue against it ? thanks!
Collaborator
|
Build success |
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Mar 2, 2018
…net#645. (dotnet#3638) * [tests] Don't run mmp regression tests in parallel. Fixes maccore dotnet#645. For some reason vstool becomes confused and starts erroring out if multiple vstools are running at the same time. So work around this by executing the MMP regression tests serialized. Fixes xamarin/maccore#645. * [xharness] Upload the logs from the mmp regression tests.
rolfbjarne
added a commit
that referenced
this pull request
Mar 5, 2018
… (#3638) (#3641) * [tests] Don't run mmp regression tests in parallel. Fixes maccore #645. For some reason vstool becomes confused and starts erroring out if multiple vstools are running at the same time. So work around this by executing the MMP regression tests serialized. Fixes xamarin/maccore#645. * [xharness] Upload the logs from the mmp regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason vstool becomes confused and starts erroring out if multiple
vstools are running at the same time.
So work around this by executing the MMP regression tests serialized.
Also pload the logs from the mmp regression tests to make diagnosis easier.
Fixes https://github.com/xamarin/maccore/issues/645.