[static registrar] Optimize creation of delegates for blocks. (#3623) #3644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#3623) * [static registrar] Optimize creation of delegates for blocks. Optimize creation of delegates for blocks so that it doesn't require the dynamic registrar. This is done by getting the metadata token for the Create method that creates the delegate, and embed that metadata token in the generated code from the static registrar. Also add tests, since this scenario was not covered by tests already. * [mmptest] Fix test after recent changes. * [test-libraries] Avoid duplicate symbols. * [tests] Update according to changes.
dalexsoto
approved these changes
Mar 2, 2018
Member
dalexsoto
left a comment
dalexsoto
left a comment
There was a problem hiding this comment.
I think this is a back port so might be late for my comments heh, otherwise LGTM 👍
| Objective-C code, in particular when it involves blocks, since it's quite | ||
| complicated to get it right when doing it manually. | ||
|
|
||
| If this is not the case, please file a bug at [https://bugzilla.xamarin.com](https://bugzilla.xamarin.com/enter_bug.cgi?product=Xamarin.Mac) with a test case. |
Member
There was a problem hiding this comment.
Should we still point people to bugzilla?
Member
Author
| Objective-C code, in particular when it involves blocks, since it's quite | ||
| complicated to get it right when doing it manually. | ||
|
|
||
| If this is not the case, please file a bug at [https://bugzilla.xamarin.com](https://bugzilla.xamarin.com/enter_bug.cgi?product=iOS) with a test case. |
Member
There was a problem hiding this comment.
same, should we still point people to bugzilla?
Contributor
|
@dalexsoto #3623 was original. |
chamons
approved these changes
Mar 2, 2018
Collaborator
|
Build failure |
Member
Author
|
Test failures are unrelated:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize creation of delegates for blocks so that it doesn't require the
dynamic registrar.
This is done by getting the metadata token for the Create method that creates
the delegate, and embed that metadata token in the generated code from the
static registrar.
Also add tests, since this scenario was not covered by tests already.
[mmptest] Fix test after recent changes.
[test-libraries] Avoid duplicate symbols.
[tests] Update according to changes.