Put a binary copy of mlaunch in macios-binaries instead of in Azure. Fixes #3316. #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes dotnet#3316. If the Xamarin build is enabled, then build mlaunch from source, otherwise get it from macios-binaries. Fixes dotnet#3316.
|
This won't work until xamarin/macios-binaries#8 is merged and bumped in this PR. |
|
Build failure !!! Couldn't read commit file !!! |
Commit list for xamarin/macios-binaries: * xamarin/macios-binaries@69a9088 Bump mlaunch to xamarin/maccore@4505cd6f02 (dotnet#8) Diff: xamarin/macios-binaries@e1e8bdf...69a9088
spouliot
approved these changes
Mar 22, 2018
|
Build success !!! Couldn't read commit file !!! |
dalexsoto
approved these changes
Mar 22, 2018
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 22, 2018
… Azure. Fixes dotnet#3316. (dotnet#3800)" This reverts commit e6c45c2. It breaks the mlaunch build.
vargaz
pushed a commit
that referenced
this pull request
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Xamarin build is enabled, then build mlaunch from source, otherwise get it from macios-binaries.
Fixes #3316.