Skip to content

Conversation

@VincentDondain
Copy link
Contributor

  • Removed new string [] { "Import", "Project" }, which is causing issues when using msbuild (hopefully it's not breaking things since we're mostly using msbuild now).

- Removed `new string [] { "Import", "Project" },` which is causing issues when using msbuild (hopefully it's not breaking things since we're mostly using msbuild now).
@VincentDondain VincentDondain added do-not-merge Do not merge this pull request run-all-tests Run all our tests. labels Mar 26, 2018
@VincentDondain
Copy link
Contributor Author

This PR is a tentative at using msbuild for our test. It needs to be tested on the bots since their setup is different than local setup (where those changes work).

@monojenkins
Copy link
Collaborator

Build failure

!!! Couldn't read commit file !!!

@VincentDondain
Copy link
Contributor Author

I hoped this PR might work on the bots as it works locally but it seems to be hitting issues due to lack of msbuild redirect.

In the tests build logs we can see a mix of /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/* and /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/* which breaks.

Might be due in part or in full to MSBuildExtensionsPath=null which is defined when using msbuild. However using something else doesn't seem to be supported by msbuild yet (tried locally).

In short, we're hitting things that @radical is trying to address in https://bugzilla.xamarin.com/show_bug.cgi?id=53164.

I'm closing this PR as he'll likely revisit switching the tests to msbuild when his fix lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Do not merge this pull request run-all-tests Run all our tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants