[backport][msbuild] Skip reference assemblies passed to mtouch (#3791) #3889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes issue dotnet#3199: Could not AOT the assembly System.Runtime.CompilerServices.Unsafe.dll (MT3001) (dotnet#3199) - Test case: https://www.dropbox.com/s/kxt3isgzn74nq35/Issue3199.zip?dl=0 ### Problem Given a Nuget Package added via the "package reference" mechanism and the said package having netstandard 'lib' **and** 'ref' folders; MTouch was getting reference assemblies and was trying to AOT them. This resulted in an error as those assemblies are only facades. ### Solution 'ResolveNuGetPackageAssets' computes the NuGet packages using their json asset file, adds the full assemblies to 'ReferenceCopyLocalPaths' and outputs the resolved references via '_ReferencesFromNuGetPackages'. This is exactly what "Microsoft.NuGet.Build.Tasks"'s 'ResolveNuGetPackageAssets' target does.
VincentDondain
requested review from
emaf,
jstedfast,
kzu and
rolfbjarne
as code owners
Contributor
Author
|
@spouliot ahem, better late than never... |
dalexsoto
approved these changes
Apr 6, 2018
Collaborator
Build success
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Could not AOT the assembly System.Runtime.CompilerServices.Unsafe.dll (MT3001) #3199)
Given a Nuget Package added via the "package reference" mechanism and the said package having netstandard 'lib' and 'ref' folders;
MTouch was getting reference assemblies and was trying to AOT them. This resulted in an error as those assemblies are only facades.
'ResolveNuGetPackageAssets' computes the NuGet packages using their json asset file, adds the full assemblies to 'ReferenceCopyLocalPaths' and outputs the resolved references via '_ReferencesFromNuGetPackages'.
This is exactly what "Microsoft.NuGet.Build.Tasks"'s 'ResolveNuGetPackageAssets' target does.