Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[messages] Updates for beta 1 #4230

Merged
merged 1 commit into from
Jun 12, 2018
Merged

[messages] Updates for beta 1 #4230

merged 1 commit into from
Jun 12, 2018

Conversation

spouliot
Copy link
Contributor

No description provided.

@spouliot spouliot requested a review from VincentDondain as a code owner June 12, 2018 16:00
@spouliot spouliot added this to the xcode10 milestone Jun 12, 2018
@monojenkins
Copy link
Collaborator

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
🔥 Test run failed 🔥

Test results

1 tests failed, 63 tests passed.

Failed tests

  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

@spouliot
Copy link
Contributor Author

known issue > Xamarin.iOS.Tasks.TargetTests.RebuildExecutable_NoModifications -> fixed (back port) with PR #4231

@spouliot spouliot merged commit d2b8669 into dotnet:xcode10 Jun 12, 2018
@spouliot spouliot deleted the xcode10-messages-beta1 branch June 12, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@VincentDondain VincentDondain Awaiting requested review from VincentDondain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
xcode10
Development

Successfully merging this pull request may close these issues.
3 participants
@spouliot @monojenkins @rolfbjarne