Skip to content

Conversation

@dalexsoto
Copy link
Member

No description provided.

@dalexsoto dalexsoto requested a review from spouliot as a code owner July 12, 2018 22:06
@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
API Diff (from PR only) (please review changes)
Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 63 tests passed.

Failed tests

  • introspection/iOS Unified 64-bits - simulator/Debug: Failed

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
API Diff (from PR only) (please review changes)
Generator Diff (please review changes)
Test run succeeded

@dalexsoto dalexsoto merged commit e944b58 into dotnet:xcode10 Jul 13, 2018
@dalexsoto dalexsoto deleted the pdfkit10b3 branch July 13, 2018 19:14
// - (instancetype)init NS_DESIGNATED_INITIALIZER;
[Export ("init")]
[DesignatedInitializer]
IntPtr Constructor ();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalexsoto we added a type-level [DesignatedDefaultCtor] last year to cover that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants