[CoreMidi] Xcode 10 beta 3 update.#4453
Conversation
|
Build success Test results1 tests failed, 63 tests passed. Failed tests
|
dalexsoto
left a comment
dalexsoto
left a comment
There was a problem hiding this comment.
Otherwise it looks good to me
src/coremidi.cs
Outdated
| string Name { get; } | ||
|
|
||
| [Export ("profileID")] | ||
| NSData ProfileID { get; } |
| [NoWatch, NoTV, Mac (10,14, onlyOn64: true), iOS (12,0)] | ||
| [StructLayout (LayoutKind.Sequential)] | ||
| public struct MidiCIDeviceIdentification | ||
| { |
chamons
left a comment
chamons
left a comment
There was a problem hiding this comment.
Agree with @dalexsoto comments but looks good, beyond our inability to test the manual bindings in particular.
mandel-macaque
force-pushed
the
coremidi-xcode10
branch
from
63efa82 to
ad0b0fc
Compare
|
Build success |
This reverts commit 53fdc01. Unfortunately there is not enough info for the AOT compiler to handle MidiCIDeviceIdentification struct and this is causing mtouch tests to fail
| #endif // !COREBUILD | ||
| } | ||
|
|
||
| public class MidiDeviceList : MidiObject { |
There was a problem hiding this comment.
@mandel-macaque: How can customers use this class? There are no static members, and no exposed constructors. The class isn't used anywhere else in the PR either.
5 participants
No description provided.