Initial OpenGL deprecation #4458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chamons
commented
Jul 17, 2018
chamons
commented
- Only on macOS
- Only a subset of the uses are deprecated, see radar://42257568
- Only on macOS - Only a subset of the uses are deprecated, see radar://42257568
Collaborator
|
Build success |
mandel-macaque
approved these changes
Jul 18, 2018
Contributor
mandel-macaque
left a comment
mandel-macaque
left a comment
There was a problem hiding this comment.
looks good, but I would move to "Use the Metal Framework instead." in the deprecation attrs.
dalexsoto
approved these changes
Jul 19, 2018
Collaborator
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.