[Tests] Add missing tests for NWPath. #4765
Conversation
| connection.SetStateChangeHandler (ConnectionStateHandler); | ||
| connection.SetQueue (DispatchQueue.MainQueue); | ||
| connection.Start (); | ||
| connectedEvent.WaitOne (500); |
There was a problem hiding this comment.
Maybe add an Assert that the WaitOne succeeded (otherwise random timeouts here will be hard to diagnose).
| i.Dispose (); | ||
| interfaces = new List<NWInterface> (); | ||
| path.EnumerateInterfaces (EnumerateInterfacesHandler); | ||
| Assert.AreNotEqual (0, interfaces.Count, "We should have at least on interface."); |
There was a problem hiding this comment.
Assert.That (interfaces.Count, Is.GreaterThan (0), "interfaces.Count"); explains it better
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
I'm curious about the all false properties before approving :)
|
|
||
| void ConnectionStateHandler (NWConnectionState state, NWError error) | ||
| { | ||
| var errno = (SslStatus)(error != null ? error.ErrorCode : 0); |
| [Test] | ||
| public void HasDnsPropertyTest () | ||
| { | ||
| Assert.False (path.HasDns); |
| i.Dispose (); | ||
| interfaces = new List<NWInterface> (); | ||
| path.EnumerateInterfaces (EnumerateInterfacesHandler); | ||
| Assert.AreNotEqual (0, interfaces.Count, "We should have at least on interface."); |
There was a problem hiding this comment.
Assert.That (interfaces.Count, Is.GreaterThan (0), "interfaces.Count"); explains it better
| if (path != null) | ||
| path.Dispose (); | ||
| foreach (var i in interfaces) | ||
| i.Dispose (); |
There was a problem hiding this comment.
you could call Dispose on connectedEvent
|
Build success |
1. Address comments of conn issues. 2. Use a unique conn for all unit tests, is expensive and we do not care in this class. 3. Modify the teardown to clean interfaces etc.. in the cancel event from the connection. 4. Move the cb execution to a diff queue to avoid been blocked. 5. Ensure tests do work on device (sim has diff results).
|
Build success |
4 participants
No description provided.