Skip to content

[security] Fix 'SecCertificate2.Certificate' call and add some tests#4783

Merged
spouliot merged 3 commits intodotnet:xcode10from
spouliot:xcode10-security-audit
Sep 11, 2018
Merged

[security] Fix 'SecCertificate2.Certificate' call and add some tests#4783
spouliot merged 3 commits intodotnet:xcode10from
spouliot:xcode10-security-audit

Conversation

@spouliot
Copy link
Contributor

@spouliot spouliot commented Sep 11, 2018

No description provided.

@spouliot spouliot requested a review from dalexsoto as a code owner September 11, 2018 00:27
@spouliot spouliot added this to the xcode10 milestone Sep 11, 2018
@monojenkins
Copy link
Collaborator

monojenkins commented Sep 11, 2018

Build failure
❌ Build was aborted

@monojenkins
Copy link
Collaborator

monojenkins commented Sep 11, 2018

Build failure
❌ Build was aborted

✅ Build succeeded
✅ API Diff (from stable)

@monojenkins
Copy link
Collaborator

monojenkins commented Sep 11, 2018

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)
✅ Test run succeeded

@spouliot spouliot merged commit 46fb26e into dotnet:xcode10 Sep 11, 2018
@spouliot spouliot deleted the xcode10-security-audit branch September 11, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto Awaiting requested review from dalexsoto dalexsoto is a code owner

+1 more reviewer

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

xcode10

Development

Successfully merging this pull request may close these issues.

4 participants

@spouliot @monojenkins @rolfbjarne @mandel-macaque