[HealthKit] Use generated NSString-backed enums. Fixes #4183. #4786
Conversation
|
@rolfbjarne the first commit does not look related |
This means less (duplicated) manual code, which means less errors, which also means we're now getting some new members that previously weren't duplicated correctly. Fixes dotnet#4183.
rolfbjarne
force-pushed
the
issue-4183
branch
from
946c175 to
d21331d
Compare
|
@spouliot fixed |
|
Build failure |
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
will be easier to review once API diff is complete :)
src/healthkit.cs
Outdated
| @@ -1433,348 +1433,338 @@ interface HKStatisticsQuery { | |||
| [Watch (2,0)] | |||
| [iOS (8,0)] | |||
| [Static] | |||
There was a problem hiding this comment.
^ not needed (and likely ignored by the generator)
|
|
||
| [Introduced (PlatformName.WatchOS, 2,0, PlatformArchitecture.All)] | ||
| [Introduced (PlatformName.iOS, 8,0, PlatformArchitecture.All)] | ||
| public unsafe static partial class HKCorrelationTypeKey { |
There was a problem hiding this comment.
missing [Obsolete] ? since it won't be in XAMCORE_4_0 ?
|
|
||
| [Introduced (PlatformName.WatchOS, 2,0, PlatformArchitecture.All)] | ||
| [Introduced (PlatformName.iOS, 8,0, PlatformArchitecture.All)] | ||
| public unsafe static partial class HKCharacteristicTypeIdentifierKey { |
There was a problem hiding this comment.
missing [Obsolete] ? since it won't be in XAMCORE_4_0 ?
|
|
||
| [Introduced (PlatformName.WatchOS, 2,0, PlatformArchitecture.All)] | ||
| [Introduced (PlatformName.iOS, 8,0, PlatformArchitecture.All)] | ||
| public unsafe static partial class HKCategoryTypeIdentifierKey { |
There was a problem hiding this comment.
missing [Obsolete] ? since it won't be in XAMCORE_4_0 ?
| namespace HealthKit { | ||
| [Introduced (PlatformName.WatchOS, 2,0, PlatformArchitecture.All)] | ||
| [Introduced (PlatformName.iOS, 8,0, PlatformArchitecture.All)] | ||
| public unsafe static partial class HKQuantityTypeIdentifierKey { |
There was a problem hiding this comment.
missing [Obsolete] ? since it won't be in XAMCORE_4_0 ?
|
Build failure Test results3 tests failed, 0 tests skipped, 77 tests passed.Failed tests
|
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
API diff is happy - except there's nothing obsoleted.
There's a failing test too
|
Build success |
4 participants
This means less (duplicated) manual code, which means less errors, which also
means we're now getting some new members that previously weren't duplicated
correctly.
Fixes #4183.