Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Add check for bluetooth permission #6796

Merged
merged 2 commits into from
Aug 21, 2019
Merged

[tests] Add check for bluetooth permission #6796

merged 2 commits into from
Aug 21, 2019

Conversation

VincentDondain
Copy link
Contributor

@VincentDondain VincentDondain commented Aug 19, 2019 •
edited
Loading

@VincentDondain VincentDondain added run-device-tests enable-device-build Makes our build include device support (which we disable for simple PRs to speed them up) labels Aug 19, 2019
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

3 tests failed, 1148 tests' device not found, 223 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: BuildFailure
  • xammac tests/Mac Modern/Release: BuildFailure
  • xammac tests/Mac Modern/Release: BuildFailure

@VincentDondain
Copy link
Contributor Author

62d0826 will have device builds results

@VincentDondain VincentDondain removed the enable-device-build Makes our build include device support (which we disable for simple PRs to speed them up) label Aug 20, 2019
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

2 tests failed, 224 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): Crashed

@VincentDondain
Copy link
Contributor Author

Known watchOS HE0038: https://github.com/xamarin/maccore/issues/581 and the device tests are no longer complaining about CBCentralManagerTest being canceled.

@VincentDondain VincentDondain merged commit 37e7023 into dotnet:xcode11 Aug 21, 2019
@VincentDondain VincentDondain deleted the xcode11-bluetooth-permissions branch August 21, 2019 10:41
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VincentDondain @monojenkins @rolfbjarne @xamarin-release-manager