[generator] Do not generate PlatformNotSupportedException in chaining .ctor #7085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .ctor Types that are new in 64bits only OS are generated differently on 32bits bindings. They mainly throw a `PlatformNotSupportedException` so it's easier to diagnose (than a crash) what's happening at runtime. This works well in all cases except one. When a new type, let's say `UIMenuElement` is added **and** serves as a new base type for existing types. `UIKeyCommand` (iOS 7) -> `UICommand` (iOS 13)-> `UIMenuElement` (iOS 13) This is _correct_ as new base types can be added (in ObjC and C#). However the generated code for the constructors of `UICommand` and `UIMenuElement` would be throwing a `PlatformNotSupportedException` which breaks the `UIKeyCommand` on 32 bits devices. We fixed this in a few places by tweaking the availability attribute but that requires spotting the new base type while doing bindings and that is error prone [1][2]. This PR simply does let the `protected` constructor, using when chaining, be generated normally. It's simpler and will cover all the cases (without requiring hacks in the availability of those types) [1] dotnet#7083 [2] dotnet#7084
rolfbjarne
approved these changes
Sep 24, 2019
spouliot
added
bug
mandel-macaque
approved these changes
Sep 24, 2019
dalexsoto
approved these changes
Sep 24, 2019
|
Build failure Test results7 tests failed, 81 tests passed.Failed tests
|
|
Build success |
|
@monojenkins backport to master |
VincentDondain
pushed a commit
to VincentDondain/xamarin-macios
that referenced
this pull request
Oct 16, 2019
… .ctor (dotnet#7085) Types that are new in 64bits only OS are generated differently on 32bits bindings. They mainly throw a `PlatformNotSupportedException` so it's easier to diagnose (than a crash) what's happening at runtime. This works well in all cases except one. When a new type, let's say `UIMenuElement` is added **and** serves as a new base type for existing types. `UIKeyCommand` (iOS 7) -> `UICommand` (iOS 13)-> `UIMenuElement` (iOS 13) This is _correct_ as new base types can be added (in ObjC and C#). However the generated code for the constructors of `UICommand` and `UIMenuElement` would be throwing a `PlatformNotSupportedException` which breaks the `UIKeyCommand` on 32 bits devices. We fixed this in a few places by tweaking the availability attribute but that requires spotting the new base type while doing bindings and that is error prone [1][2]. This PR simply does let the `protected` constructor, using when chaining, be generated normally. It's simpler and will cover all the cases (without requiring hacks in the availability of those types) [1] dotnet#7083 [2] dotnet#7084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types that are new in 64bits only OS are generated differently on 32bits
bindings. They mainly throw a
PlatformNotSupportedExceptionso it'seasier to diagnose (than a crash) what's happening at runtime.
This works well in all cases except one. When a new type, let's say
UIMenuElementis added and serves as a new base type for existingtypes.
UIKeyCommand(iOS 7) ->UICommand(iOS 13)->UIMenuElement(iOS 13)This is correct as new base types can be added (in ObjC and C#).
However the generated code for the constructors of
UICommandandUIMenuElementwould be throwing aPlatformNotSupportedExceptionwhich breaks the
UIKeyCommandon 32 bits devices.We fixed this in a few places by tweaking the availability attribute
but that requires spotting the new base type while doing bindings and
that is error prone [1][2].
This PR simply does let the
protectedconstructor, using when chaining,be generated normally. It's simpler and will cover all the cases (without
requiring hacks in the availability of those types)
[1] #7083
[2] #7084