Skip to content

Commit

Permalink
Disable Git.Build.targets
Browse files Browse the repository at this point in the history
Was pulling my hair out over this thing...

This caused nonsensical errors from the dotnet/sdk:

    test.csproj warning MSB4243: The NuGet-based SDK resolver failed to run because NuGet assemblies could not be located.  Check your installation of MSBuild or set the environment variable "MSBUILD_NUGET_PATH" to the folder that contains the required NuGet assemblies. Could not find file 'd:\agent\1\s\bin\dotnet\sdk-manifests\6.0.100\gitinfo\WorkloadManifest.json'.

`gitinfo` was being dropped in the `dotnet/sdk-manifests` folder, and
it's trying to be loaded as a workload:

    sdk-manifests\6.0.100\gitinfo\WorkloadManifest.json
  • Loading branch information
jonathanpeppers committed Mar 16, 2021
1 parent 70bdf6a commit 04b3fb9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project>
<Import Condition="'$(SampleProject)' != 'true' and '$(CI)' == 'true'" Project="eng\Git.Build.targets" />
<Import Condition="'$(SampleProject)' != 'true' and '$(CI)' == 'true' and '$(DisableGitInfo)' != 'true' " Project="eng\Git.Build.targets" />
<Import Condition="'$(SampleProject)' != 'true' and '$(CI)' == 'true' " Project="eng\Version.targets" />
<Import Project="eng\AndroidX.targets" />
<Import Project="eng\Microsoft.Extensions.targets" />
Expand Down
1 change: 1 addition & 0 deletions src/DotNet/Dependencies/Packs.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project Sdk="Microsoft.Build.NoTargets">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<DisableGitInfo>true</DisableGitInfo>
</PropertyGroup>
<ItemGroup>
<PackageDownload Include="Microsoft.Android.Ref" Version="[$(MicrosoftAndroidSdkPackageVersion)]" />
Expand Down
1 change: 1 addition & 0 deletions src/DotNet/Dependencies/Workloads.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project Sdk="Microsoft.Build.NoTargets">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<DisableGitInfo>true</DisableGitInfo>
</PropertyGroup>
<ItemGroup>
<PackageDownload Include="Microsoft.NET.Workload.Android" Version="[$(MicrosoftAndroidSdkPackageVersion)]" />
Expand Down
1 change: 1 addition & 0 deletions src/DotNet/DotNet.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IsPackable>false</IsPackable>
<DisableGitInfo>true</DisableGitInfo>
<MauiOutputPath>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)../../bin/'))</MauiOutputPath>
<DotNetDirectory>$(MauiOutputPath)dotnet/</DotNetDirectory>
<DotNetToolPath>$(DotNetDirectory)dotnet</DotNetToolPath>
Expand Down

0 comments on commit 04b3fb9

Please sign in to comment.