Fix BoxView not rendering when is hidden on start (#21960)

* Update BoxView.cs Added a sample to UITest Update BoxView.cs Update Issue19926.cs * Updated screenshot
dotnet · Dec 6, 2024 · 096ae74 · 096ae74
1 parent 7bfe434
commit 096ae74
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 1 deletion.
diff --git a/src/Controls/src/Core/BoxView/BoxView.cs b/src/Controls/src/Core/BoxView/BoxView.cs
@@ -57,6 +57,7 @@ protected override void OnPropertyChanged([CallerMemberName] string? propertyNam
 
 			if (propertyName == BackgroundColorProperty.PropertyName ||
 				propertyName == ColorProperty.PropertyName ||
+				propertyName == IsVisibleProperty.PropertyName ||
 				propertyName == BackgroundProperty.PropertyName ||
 				propertyName == CornerRadiusProperty.PropertyName)
 				Handler?.UpdateValue(nameof(IShapeView.Shape));

diff --git a/...estCases.Android.Tests/snapshots/android/PropertiesShouldBeCorrectlyApplied.png b/...estCases.Android.Tests/snapshots/android/PropertiesShouldBeCorrectlyApplied.png
diff --git a/src/Controls/tests/TestCases.HostApp/Issues/Issue19926.xaml b/src/Controls/tests/TestCases.HostApp/Issues/Issue19926.xaml
@@ -32,5 +32,17 @@
             <Label HorizontalTextAlignment="Center" Text="Scale X"/>
             <BoxView ScaleX="1.5"/>
         </StackLayout>
+
+        <StackLayout>
+            <Button
+                Text="Click to show a BoxView"
+                Clicked="Button_Clicked"
+                AutomationId="button"/>
+            <BoxView
+                x:Name="boxView"
+                AutomationId="boxView2"
+                HorizontalOptions="Center"
+                IsVisible="False"/>
+        </StackLayout>
     </StackLayout>
 </ContentPage>
diff --git a/src/Controls/tests/TestCases.HostApp/Issues/Issue19926.xaml.cs b/src/Controls/tests/TestCases.HostApp/Issues/Issue19926.xaml.cs
@@ -8,4 +8,9 @@ public Issue19926()
 	{
 		InitializeComponent();
 	}
+
+	void Button_Clicked(object sender, System.EventArgs e)
+	{
+		boxView.IsVisible = true;
+	}
 }
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19926.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19926.cs
@@ -15,10 +15,14 @@ public Issue19926(TestDevice device)
 
 	[Test]
 	[Category(UITestCategories.BoxView)]
-	public void PropertiesShouldBeCorrectlyApplied()
+	public async Task PropertiesShouldBeCorrectlyApplied()
 	{
 		_ = App.WaitForElement("boxView");
+		App.Click("button");
+		_ = App.WaitForElement("boxView2");
 
+		// A small delay to wait for the button ripple effect animation to complete.
+		await Task.Delay(500);
 		VerifyScreenshot();
 	}
 }