Weak Parent

src/Controls/src/Core/Element/Element.cs

@@ -68,7 +68,7 @@ public abstract partial class Element : BindableObject, IElementDefinition, INam
 
 		Guid? _id;
 
-		Element _parentOverride;
+		WeakReference<Element> _parentOverride;
 
 		string _styleId;
 
@@ -282,10 +282,26 @@ internal bool RemoveLogicalChild(Element element, int index)
 
 		internal Element ParentOverride
 		{
-			get { return _parentOverride; }
+			get 
+			{
+				if (_parentOverride is null)
+				{
+					return null;
+				}
+				if (_parentOverride.TryGetTarget(out var parent))
+				{
+					return parent;
+				}
+				else
+				{
+					// Log an error because this should never happen
+				}
+
+				return null;
+			}
 			set
 			{
-				if (_parentOverride == value)
+				if (ParentOverride == value)
 					return;
 
 				bool emitChange = Parent != value;
@@ -300,7 +316,10 @@ internal Element ParentOverride
 						OnParentChangingCore(Parent, RealParent);
 				}
 
-				_parentOverride = value;
+				if (value == null)
+					_parentOverride = null;
+				else
+					_parentOverride = new WeakReference<Element>(value);
 
 				if (emitChange)
 				{
@@ -310,9 +329,36 @@ internal Element ParentOverride
 			}
 		}
 
+		WeakReference<Element> _realParent;
 		/// <summary>For internal use by .NET MAUI.</summary>
 		[EditorBrowsable(EditorBrowsableState.Never)]
-		public Element RealParent { get; private set; }
+		public Element RealParent 
+		{ 
+			get
+			{
+				if (_realParent is null)
+				{
+					return null;
+				}
+				if (_realParent.TryGetTarget(out var parent))
+				{
+					return parent;
+				}
+				else
+				{
+					// Log an error because this should never happen
+				}
+
+				return null;
+			} 
+			private set
+			{
+				if (value is null)
+					_realParent = null;
+				else
+					_realParent = new WeakReference<Element>(value);
+			}
+		}
 
 		Dictionary<BindableProperty, (string, SetterSpecificity)> DynamicResources => _dynamicResources ?? (_dynamicResources = new Dictionary<BindableProperty, (string, SetterSpecificity)>());
 
@@ -328,7 +374,7 @@ void IElementDefinition.AddResourcesChangedListener(Action<object, ResourcesChan
 		/// <remarks>Most application authors will not need to set the parent element by hand.</remarks>
 		public Element Parent
 		{
-			get { return _parentOverride ?? RealParent; }
+			get { return ParentOverride ?? RealParent; }
 			set => SetParent(value);
 		}