prevent multiple enumerations

dotnet · Jan 18, 2024 · 9ba2780 · 9ba2780
1 parent 8821d48
commit 9ba2780
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/Core/src/Core/Extensions/VisualTreeElementExtensions.cs b/src/Core/src/Core/Extensions/VisualTreeElementExtensions.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.Maui.Graphics;
@@ -145,11 +145,18 @@ static List<IVisualTreeElement> GetVisualTreeElementsWindowsInternal(IVisualTree
 
 			if (uiElement != null)
 			{
-				var uniqueElements = findChildren(uiElement).Distinct();
-				var viewTree = visualElement.GetVisualTreeDescendants().Where(n => n is IView view && view.Handler is not null).Select(n => new Tuple<IView, object?>((IView)n, ((IView)n).ToPlatform()));
-				var testList = viewTree.Where(n => uniqueElements.Contains(n.Item2)).Select(n => n.Item1);
+				var uniqueElements = findChildren(uiElement).ToHashSet();
+
+				var viewTree = visualElement.GetVisualTreeDescendants()
+					.Where(n => n is IView view && view.Handler is not null)
+					.Select(n => new Tuple<IView, object?>((IView)n, ((IView)n).ToPlatform()))
+					.ToList();
+
+				var testList = viewTree.Where(n => uniqueElements.Contains(n.Item2))
+					.Select(n => n.Item1);
+
 				if (testList != null && testList.Any())
-					visualElements.AddRange(testList.Select(n => (IVisualTreeElement)n));
+					visualElements.AddRange(testList.Cast<IVisualTreeElement>());
 			}
 
 			visualElements.Reverse();