Skip to content

Commit

Permalink
Revert default for UseSafeAreaProperty to value from .NET 6 for iOS (#…
Browse files Browse the repository at this point in the history
…16093) (#16379)

* Revert default for UseSafeAreaProperty to value from .NET 6 for iOS
Fixes #12823

* Update to ignore broken iOS test for now

* Fix shell tab test
# Conflicts:
#	src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.iOS.cs
#	src/Controls/tests/DeviceTests/Elements/TabbedPage/TabbedPageTests.cs

Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>
  • Loading branch information
PureWeen and hartez authored Aug 19, 2023
1 parent d98388e commit d47c215
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@ public static IPlatformElementConfiguration<iOS, FormsElement> SetPreferredStatu
}

/// <summary>Bindable property for attached property <c>UseSafeArea</c>.</summary>
#if MACCATALYST
public static readonly BindableProperty UseSafeAreaProperty = BindableProperty.Create("UseSafeArea", typeof(bool), typeof(Page), true);
#else
public static readonly BindableProperty UseSafeAreaProperty = BindableProperty.Create("UseSafeArea", typeof(bool), typeof(Page), false);
#endif

/// <include file="../../../../docs/Microsoft.Maui.Controls.PlatformConfiguration.iOSSpecific/Page.xml" path="//Member[@MemberName='GetUseSafeArea']/Docs/*" />
public static bool GetUseSafeArea(BindableObject element)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ await CreateHandlerAndAddToWindow<WindowHandlerStub>(new Window(navPage), async
});
}

#if IOS
[Theory(Skip = "Test doesn't work on iOS yet; probably because of https://github.com/dotnet/maui/issues/10591")]
#else
[Theory]
#endif
#if ANDROID
[InlineData(true)]
#endif
Expand Down

0 comments on commit d47c215

Please sign in to comment.